-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.net core support #63
Comments
Perhaps as part of 2.0. Haven't really looked into it. |
Okay thanks. |
Just what's tracked here: https://github.com/ithielnor/harvest.net/milestone/2 |
I'll gladly take this one once #75 is confirmed good to go and merged in. |
Refit is a good replacement for restsharp, if it still doesn't support net core. |
I just converted it to .Net Standard 2.0 for my personal project. The unit tests all pass, but I don't know if it's worth making a PR for or not because I had to convert the visual basic TextFieldParser to a CvsHelper project I found in Nuget and I don't use that functionality, so I can't guarantee I did it correctly. It's here if anyone wants it: https://github.com/lprichar/harvest.net and I'm happy to make a PR if the authors would like. |
@lprichar Awesome, this is only possible now because RestSharp now supports .NET Standard 2.0. It didn't at the time that I started a rather ambitious rewrite. I'd still like to continue down that path but it's of less importance now. Please create a PR, I'd like to review and help test. |
@lprichar Looks cool. Can you submit a PR to 2.0? |
@lprichar Can you make a PR for this? I've successfully tested it and at least for my use it works well. |
I'm happy to PR it against master, but redoing it for 2.0 would be non-trivial. I guess I'll just do that, and then the maintainers (@ithielnor) can reject it, and I won't be mortally offended. |
At this point, I'd consider your port to .NET Standard to be 2.0, and any future refactorings/rewrites to be 3.0+. "Perfect is the enemy of the good" and all. |
Are you planning to support .net core?
I know restsharp does not have .net core support yet.
The text was updated successfully, but these errors were encountered: