Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.net core support #63

Open
asoet opened this issue Dec 22, 2016 · 11 comments
Open

.net core support #63

asoet opened this issue Dec 22, 2016 · 11 comments

Comments

@asoet
Copy link

asoet commented Dec 22, 2016

Are you planning to support .net core?
I know restsharp does not have .net core support yet.

@ithielnor ithielnor added this to the 2.0 milestone Dec 23, 2016
@ithielnor
Copy link
Owner

Perhaps as part of 2.0. Haven't really looked into it.

@asoet
Copy link
Author

asoet commented Jan 20, 2017

Okay thanks.
Do you have a roadmap?

@ithielnor
Copy link
Owner

Just what's tracked here: https://github.com/ithielnor/harvest.net/milestone/2

@paulirwin
Copy link
Contributor

I'll gladly take this one once #75 is confirmed good to go and merged in.

@kfrancis
Copy link

kfrancis commented Sep 28, 2017

Refit is a good replacement for restsharp, if it still doesn't support net core.

@lprichar
Copy link

I just converted it to .Net Standard 2.0 for my personal project. The unit tests all pass, but I don't know if it's worth making a PR for or not because I had to convert the visual basic TextFieldParser to a CvsHelper project I found in Nuget and I don't use that functionality, so I can't guarantee I did it correctly. It's here if anyone wants it: https://github.com/lprichar/harvest.net and I'm happy to make a PR if the authors would like.

@paulirwin
Copy link
Contributor

@lprichar Awesome, this is only possible now because RestSharp now supports .NET Standard 2.0. It didn't at the time that I started a rather ambitious rewrite. I'd still like to continue down that path but it's of less importance now. Please create a PR, I'd like to review and help test.

@ithielnor
Copy link
Owner

@lprichar Looks cool. Can you submit a PR to 2.0?

@paulirwin
Copy link
Contributor

@lprichar Can you make a PR for this? I've successfully tested it and at least for my use it works well.

@lprichar
Copy link

I'm happy to PR it against master, but redoing it for 2.0 would be non-trivial. I guess I'll just do that, and then the maintainers (@ithielnor) can reject it, and I won't be mortally offended.

@paulirwin
Copy link
Contributor

At this point, I'd consider your port to .NET Standard to be 2.0, and any future refactorings/rewrites to be 3.0+. "Perfect is the enemy of the good" and all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants