chore!: change eth_price to native_price on Quote#1366
Open
Peponks9 wants to merge 2 commits intoithacaxyz:mainfrom
Open
chore!: change eth_price to native_price on Quote#1366Peponks9 wants to merge 2 commits intoithacaxyz:mainfrom
eth_price to native_price on Quote#1366Peponks9 wants to merge 2 commits intoithacaxyz:mainfrom
Conversation
klkvr
reviewed
Sep 10, 2025
klkvr
approved these changes
Sep 11, 2025
Member
klkvr
left a comment
klkvr
left a comment
There was a problem hiding this comment.
lgtm, though this is breaking so I'd like to hold this off until v25
klkvr
changed the title
eth_price to native_price on Quoteeth_price to native_price on Quote
Contributor
|
my bad, forgot about this one for v26. will be sure to include it in v27 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes Made
native_priceinstead ofeth_price.Testing
Closes #1243
cc @joshieDo