Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement options schemas #133

Open
pcasa opened this issue Apr 30, 2018 · 4 comments
Open

feat: implement options schemas #133

pcasa opened this issue Apr 30, 2018 · 4 comments
Assignees

Comments

@pcasa
Copy link

pcasa commented Apr 30, 2018

Was using the CLI. Below was what I was using before.

webfont ./*.svg --dest ./icon-dist -f icon --center-horizontally --fixed-width --fontName myCustom --template css --css-template-class-name my-custom --normalize

Now it partially builds the CSS file, but src is empty. Also, none of the fonts are actually built, so icon-dist folder only has the CSS file.

@alexander-akait
Copy link
Member

@pcasa hm, can you create minimum reproducible test repo? Also provide you node version

@pcasa
Copy link
Author

pcasa commented Apr 30, 2018

Actually, fixed. Think I had an old option -f icon that I removed. Also changed --css-template-class-name to --template-class-name and everything outputs the same as before.

Can close. Bad options passed in causing it to fail.

@alexander-akait
Copy link
Member

@pcasa looks like will be great implement schema for options to avoid future problem

@alexander-akait alexander-akait changed the title Partially creates CSS file but no fonts feat: implement options schemas Apr 30, 2018
@jimmyandrade jimmyandrade added this to the next milestone Sep 29, 2020
@jimmyandrade
Copy link
Collaborator

@pcasa looks like will be great implement schema for options to avoid future problem

@evilebottnawi what would this scheme look like?

@jimmyandrade jimmyandrade removed this from the next milestone Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants