Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Deflate.cs #33

Closed
wants to merge 1 commit into from
Closed

Update Deflate.cs #33

wants to merge 1 commit into from

Conversation

p3p3pp3
Copy link
Contributor

@p3p3pp3 p3p3pp3 commented May 29, 2024

fixed a bug in calculating the size of the pending buffer.
In certain PDF generation scenarios, this bug can lead to the following problems:

System.IndexOutOfRangeException: Index was outside the bounds of the array.
at System.util.zlib.Tree.d_code(Int32 dist)

ArrayIndexOutOfBoundsException in Tree.d_code
@yulian-gaponenko
Copy link
Member

Hi @p3p3pp3 ,
Thank you for your contribution!

Do you think it would be possible to add a test reproducing the problem? Or perhaps guide us to help reproduce it on our end?

And one more thing, would you mind signing the Contributor License Agreement?
The details are available at https://itextpdf.com/en/how-buy/legal/itext-contributor-license-agreement
We need it in order to be able to merge your PR

@p3p3pp3
Copy link
Contributor Author

p3p3pp3 commented Jun 3, 2024

Hi @p3p3pp3 , Thank you for your contribution!

Do you think it would be possible to add a test reproducing the problem? Or perhaps guide us to help reproduce it on our end?

And one more thing, would you mind signing the Contributor License Agreement? The details are available at https://itextpdf.com/en/how-buy/legal/itext-contributor-license-agreement We need it in order to be able to merge your PR

I have a data file that reproduces the issue, an image, but this image is a stamp, I can't upload it to GitHub, that would cause legal trouble. Can you give me an email address? I'll be happy to send you the test code and this file for confirmation.

@avlemos
Copy link

avlemos commented Jun 13, 2024

@p3p3pp3 , feel free to email me at andre.lemos @ itext pdf . com

@vitali-pr
Copy link
Contributor

I found the file to test on at https://issues.jenkins.io/browse/JENKINS-19473 and reproduced the issue.

But @p3p3pp3 , we still don't see you signed Contributor License Agreement. Could you, please sign it?

@p3p3pp3
Copy link
Contributor Author

p3p3pp3 commented Jun 25, 2024

Hi @vitali-pr , I've emailed a signed CLA to dev.intern @ itextpdf.com

@vitali-pr
Copy link
Contributor

@p3p3pp3 , your PR has been merged, see commit 15daf08
The test has been added in commit 7bebec3

Thanks for contributing.

@vitali-pr vitali-pr closed this Jun 26, 2024
@p3p3pp3 p3p3pp3 deleted the patch-1 branch June 27, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants