Skip to content

Pin funcy dependency. #9276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Pin funcy dependency. #9276

wants to merge 1 commit into from

Conversation

srdecny
Copy link

@srdecny srdecny commented Mar 29, 2023

See #9275

Funcy released version 2.0 yesterday which doesn't work anymore. Version 1.18 still works.

@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (35bb261) 92.86% compared to head (6a2cd68) 92.85%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9276      +/-   ##
==========================================
- Coverage   92.86%   92.85%   -0.02%     
==========================================
  Files         459      459              
  Lines       37149    37149              
  Branches     5357     5356       -1     
==========================================
- Hits        34499    34494       -5     
- Misses       2120     2123       +3     
- Partials      530      532       +2     

see 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@skshetry
Copy link
Collaborator

skshetry commented Mar 29, 2023

Thank you for contributing. But I don't think we should pin. We can just replace the offending import.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants