Skip to content

Commit be824ed

Browse files
authored
render: avoid deepcopying (#9033)
* render: avoid deepcopying * remove unnecessary line
1 parent cbe46cc commit be824ed

File tree

2 files changed

+2
-5
lines changed

2 files changed

+2
-5
lines changed

dvc/render/convert.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,10 +29,8 @@ def _group_by_rev(datapoints):
2929

3030

3131
def to_json(renderer, split: bool = False) -> List[Dict]:
32-
from copy import deepcopy
33-
3432
if renderer.TYPE == "vega":
35-
grouped = _group_by_rev(deepcopy(renderer.datapoints))
33+
grouped = _group_by_rev(renderer.datapoints)
3634
if split:
3735
content = renderer.get_filled_template(skip_anchors=["data"])
3836
else:

dvc/render/converter/vega.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
from copy import deepcopy
21
from typing import Any, Dict, Iterable, List, Optional, Tuple, Union
32

43
from funcy import first, last
@@ -233,7 +232,7 @@ def flat_datapoints(self, revision): # noqa: C901
233232
for i, (y_file, y_field) in enumerate(ys):
234233
if num_xs > 1:
235234
x_file, x_field = xs[i]
236-
datapoints = deepcopy(file2datapoints.get(y_file, []))
235+
datapoints = [d.copy() for d in file2datapoints.get(y_file, [])]
237236

238237
if props_update.get("y", None) == "dvc_inferred_y_value":
239238
_update_from_field(

0 commit comments

Comments
 (0)