Skip to content

Commit 12f0bf5

Browse files
committed
deps: bump dvc-render>0.2.0.
For iterative/dvc-render#124
1 parent 58029e9 commit 12f0bf5

File tree

5 files changed

+6
-8
lines changed

5 files changed

+6
-8
lines changed

dvc/commands/plots.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import argparse
2-
import json
32
import logging
43
import os
54

@@ -136,7 +135,7 @@ def run(self) -> int: # noqa: C901, PLR0911, PLR0912
136135
if self.args.show_vega:
137136
renderer = first(filter(lambda r: r.TYPE == "vega", renderers))
138137
if renderer:
139-
ui.write_json(json.loads(renderer.get_filled_template()))
138+
ui.write_json(renderer.get_filled_template())
140139
return 0
141140

142141
output_file: Path = (Path.cwd() / out).resolve() / "index.html"

dvc/render/convert.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
import json
21
from collections import defaultdict
32
from typing import Dict, List, Union
43

@@ -40,7 +39,7 @@ def to_json(renderer, split: bool = False) -> List[Dict]:
4039
{
4140
TYPE_KEY: renderer.TYPE,
4241
REVISIONS_KEY: sorted(grouped.keys()),
43-
"content": json.loads(content),
42+
"content": content,
4443
"datapoints": grouped,
4544
}
4645
]

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ dependencies = [
3636
"dpath<3,>=2.1.0",
3737
"dvc-data>=0.44.0,<0.45",
3838
"dvc-http",
39-
"dvc-render>=0.1.2",
39+
"dvc-render>=0.3.0,<0.4.0",
4040
"dvc-studio-client>=0.5.0,<1",
4141
"dvc-task>=0.2.0,<1",
4242
"flatten_dict<1,>=0.4.1",

tests/unit/command/test_plots.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ def test_plots_diff_vega(dvc, mocker, capsys, plots_data):
129129
mocker.patch("dvc.repo.plots.diff.diff", return_value=plots_data)
130130
mocker.patch(
131131
"dvc_render.VegaRenderer.get_filled_template",
132-
return_value=json.dumps({"this": "is vega json"}),
132+
return_value={"this": "is vega json"},
133133
)
134134
render_mock = mocker.patch("dvc_render.render_html")
135135
assert cmd.run() == 0

tests/unit/render/test_convert.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
def test_to_json_vega(mocker):
66
vega_renderer = mocker.MagicMock()
77
vega_renderer.TYPE = "vega"
8-
vega_renderer.get_filled_template.return_value = '{"this": "is vega"}'
8+
vega_renderer.get_filled_template.return_value = {"this": "is vega"}
99
vega_renderer.datapoints = [
1010
{
1111
"x": 1,
@@ -50,7 +50,7 @@ def test_to_json_vega(mocker):
5050
def test_to_json_vega_split(mocker):
5151
vega_renderer = mocker.MagicMock()
5252
vega_renderer.TYPE = "vega"
53-
vega_renderer.get_filled_template.return_value = '{"this": "is split vega"}'
53+
vega_renderer.get_filled_template.return_value = {"this": "is split vega"}
5454
vega_renderer.datapoints = [
5555
{
5656
"x": 1,

0 commit comments

Comments
 (0)