Skip to content

Use dvc_... fields from https://github.com/iterative/dvc/pull/9019 #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from

Conversation

dberenbaum
Copy link
Contributor

Fixes iterative/dvc#9018.

Depends on iterative/dvc#9019.

This incorporates the fields introduced by the linked DVC pull request into the vega-lite templates. Before this PR, the templates relied on a rev field that concatenated a bunch of internal DVC data (revision, filename, field name). This utilizes individual dvc_... fields to be able to use that data granularly in the templates.

@dberenbaum dberenbaum marked this pull request as ready for review March 11, 2023 19:37
@codecov-commenter
Copy link

codecov-commenter commented Mar 11, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (14f91b2) 96.55% compared to head (1cdf98f) 96.55%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #119   +/-   ##
=======================================
  Coverage   96.55%   96.55%           
=======================================
  Files          19       19           
  Lines         697      697           
  Branches      100      100           
=======================================
  Hits          673      673           
  Misses         20       20           
  Partials        4        4           
Impacted Files Coverage Δ
src/dvc_render/vega_templates.py 98.27% <ø> (ø)
tests/test_vega.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dberenbaum
Copy link
Contributor Author

Summary of changes in the PR:

  • Set color by dvc_rev
  • Set strokeDash by dvc_filename
  • Set shape by dvc_field
  • Use transparent fill to fix strokeDash legend formatting (otherwise shows all black filled circles)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

plots: improve vs code/studio integration
2 participants