Skip to content

fix(upload/272): don't magically set filename on set file content #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 10, 2023

Conversation

shcheklein
Copy link
Member

@shcheklein shcheklein commented Apr 7, 2023

Fixes #272

I don't see a good reason to keep this behavior. Magic that is not consistent with other Set*Content methods.

Downside of this approach is that it breaks the compatibility a bit. Let's see how it goes, we might release a major / minor version.


TODO:

  • Add tests
  • Check docs and examples
  • Bump at least a minor version after release since it changes the behavior a bit

@shcheklein shcheklein temporarily deployed to internal April 7, 2023 22:07 — with GitHub Actions Inactive
@shcheklein shcheklein self-assigned this Apr 7, 2023
@shcheklein shcheklein added the bug Something isn't working label Apr 7, 2023
@shcheklein shcheklein temporarily deployed to internal April 8, 2023 17:10 — with GitHub Actions Inactive
@shcheklein shcheklein temporarily deployed to internal April 9, 2023 15:17 — with GitHub Actions Inactive
@shcheklein shcheklein temporarily deployed to internal April 9, 2023 20:04 — with GitHub Actions Inactive
@shcheklein shcheklein requested a review from efiop April 9, 2023 20:06
@shcheklein shcheklein temporarily deployed to internal April 9, 2023 20:18 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

#223 silently renames file on update by ID
2 participants