test fix-163: thread safe auth on load and save credentials

Author: shcheklein

pydrive2/test/settings/test_oauth_test_08.yaml

@@ -0,0 +1,8 @@
+client_config_backend: service
+service_config:
+  client_json_file_path: /tmp/pydrive2/credentials.json
+
+save_credentials: False
+
+oauth_scope:
+  - https://www.googleapis.com/auth/drive

pydrive2/test/settings/test_oauth_test_09.yaml

@@ -0,0 +1,10 @@
+client_config_backend: service
+service_config:
+  client_json_file_path: /tmp/pydrive2/credentials.json
+
+save_credentials: True
+save_credentials_backend: file
+save_credentials_file: credentials/9.dat
+
+oauth_scope:
+  - https://www.googleapis.com/auth/drive

pydrive2/test/test_oauth.py

@@ -8,6 +8,7 @@
     delete_file,
     settings_file_path,
 )
+from oauth2client.file import Storage
 
 
 def setup_module(module):
@@ -99,6 +100,31 @@ def test_07_ServiceAuthFromSavedCredentialsJsonFile():
     time.sleep(1)
 
 
+def test_08_ServiceAuthFromJsonFileNoCredentialsSaving():
+    # Test that no credentials are saved and API is still functional
+    # We are testing that there are no exceptions at least
+    ga = GoogleAuth(settings_file_path("test_oauth_test_08.yaml"))
+    assert not ga.settings["save_credentials"]
+    ga.ServiceAuth()
+    time.sleep(1)
+
+
+def test_09_SaveLoadCredentialsUsesDefaultStorage(mocker):
+    # Test fix for https://github.com/iterative/PyDrive2/issues/163
+    # Make sure that Load and Save credentials by default reuse the
+    # same Storage (since it defined lock which make it TS)
+    ga = GoogleAuth(settings_file_path("test_oauth_test_09.yaml"))
+    credentials_file = ga.settings["save_credentials_file"]
+    # Delete old credentials file
+    delete_file(credentials_file)
+    assert not os.path.exists(credentials_file)
+    spy = mocker.spy(Storage, "__init__")
+    ga.ServiceAuth()
+    ga.LoadCredentials()
+    ga.SaveCredentials()
+    assert spy.call_count == 0
+
+
 def CheckCredentialsFile(credentials, no_file=False):
     ga = GoogleAuth(settings_file_path("test_oauth_default.yaml"))
     ga.LoadCredentialsFile(credentials)