Skip to content

Commit 078ec7d

Browse files
authored
hot fix and lint fix (#73)
1 parent 06e2e70 commit 078ec7d

9 files changed

Lines changed: 17 additions & 17317 deletions

File tree

dist/itemsjs.js

Lines changed: 8 additions & 17268 deletions
Large diffs are not rendered by default.

dist/itemsjs.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

docs/minisearch-integration.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
```js
44
const MiniSearch = require('minisearch');
5-
const ItemsJS = require('./../../itemsjs/src/index');
5+
const ItemsJS = require('itemsjs');
66

77
const data = [{
88
id: 1,

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "itemsjs",
3-
"version": "2.1.0",
3+
"version": "2.1.1",
44
"description": "Created to perform fast search on small json dataset (up to 1000 elements).",
55
"main": "lib/index.js",
66
"scripts": {

src/fulltext.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
const _ = require('./../vendor/lodash');
22
const lunr = require('lunr');
3-
const FastBitSet = require('fastbitset');
43

54
/**
65
* responsible for making full text searching on items
@@ -52,7 +51,7 @@ Fulltext.prototype = {
5251
search_full: function(query, filter) {
5352
return this.search(query, filter).map(v => {
5453
return this.store[v];
55-
})
54+
});
5655
},
5756

5857
search: function(query, filter) {

src/index.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ const service = require('./lib');
22
const helpers = require('./helpers');
33
const Fulltext = require('./fulltext');
44
const Facets = require('./facets');
5-
const Storage = require('./storage');
65

76
module.exports = function itemsjs(items, configuration) {
87

@@ -19,7 +18,6 @@ module.exports = function itemsjs(items, configuration) {
1918

2019
// index facets
2120
let facets = new Facets(items, configuration.aggregations);
22-
let storage = new Storage(items);
2321

2422
return {
2523
/**

src/lib.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ module.exports.search = function(items, input, configuration, fulltext, facets)
7979
return filtered_indexes_bitmap.has(v);
8080
});
8181

82-
filtered_items_indexes = filtered_indexes.slice((page - 1) * per_page, page * per_page);
82+
const filtered_items_indexes = filtered_indexes.slice((page - 1) * per_page, page * per_page);
8383
filtered_items = filtered_items_indexes.map(_id => {
8484
return facets.get_item(_id);
8585
});

src/storage.js

Lines changed: 0 additions & 37 deletions
This file was deleted.

tests/fulltextSpec.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -103,12 +103,12 @@ describe('fulltext', function() {
103103
});
104104

105105

106-
it('returns internal ids', function test(done) {
106+
xit('returns internal ids', function test(done) {
107107

108108
const fulltext = new Fulltext(items);
109-
//assert.deepEqual(fulltext.internal_ids(), [1, 2, 3]);
110-
//assert.deepEqual(fulltext.bits_ids().array(), [1, 2, 3]);
111-
//assert.deepEqual(fulltext.get_item(1).name, 'Godfather');
109+
assert.deepEqual(fulltext.internal_ids(), [1, 2, 3]);
110+
assert.deepEqual(fulltext.bits_ids().array(), [1, 2, 3]);
111+
assert.deepEqual(fulltext.get_item(1).name, 'Godfather');
112112

113113
done();
114114
});

0 commit comments

Comments
 (0)