From db3fdfbcb68bb83fab9c0f3c9cb282e41297fa70 Mon Sep 17 00:00:00 2001 From: Daniel Bevenius Date: Mon, 19 Aug 2019 14:09:12 +0200 Subject: [PATCH] build: move tooltest to before jstest target This commit moves the tooltest target to come before the jstest target to make the console output consistent with it was before I introduced the tooltest target. Currently the output looks like this which is might give the impression that only one test was run: /Applications/Xcode.app/Contents/Developer/usr/bin/make -s tooltest . ---------------------------------------------------------------------- Ran 1 test in 0.000s Compared to the usual: [03:58|% 100|+ 2739|- 0]: Done PR-URL: https://github.com/nodejs/node/pull/29220 Reviewed-By: Joyee Cheung Reviewed-By: Ruben Bridgewater Reviewed-By: James M Snell --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 58f4cc7a5795b8..478326e2cd851c 100644 --- a/Makefile +++ b/Makefile @@ -313,13 +313,13 @@ coverage-run-js: .PHONY: test # This does not run tests of third-party libraries inside deps. test: all ## Runs default tests, linters, and builds docs. + $(MAKE) -s tooltest $(MAKE) -s test-doc $(MAKE) -s build-addons $(MAKE) -s build-js-native-api-tests $(MAKE) -s build-node-api-tests $(MAKE) -s cctest $(MAKE) -s jstest - $(MAKE) -s tooltest .PHONY: test-only test-only: all ## For a quick test, does not run linter or build docs.