Skip to content

Commit 5a2bf12

Browse files
author
Madison Bahmer
committed
make rest service py2/py3 compatible
New UI branch updates altered things slightly
1 parent 229bdce commit 5a2bf12

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

rest/rest_service.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
import logging
1919
import json
2020
import threading
21+
from six import string_types
2122

2223
from kafka import KafkaConsumer, KafkaProducer
2324
from kafka.common import KafkaError
@@ -40,7 +41,7 @@
4041

4142
def crossdomain(origin='*', max_age=21600, attach_to_all=True, automatic_options=True):
4243

43-
if not isinstance(origin, basestring):
44+
if not isinstance(origin, string_types):
4445
origin = ', '.join(origin)
4546
if isinstance(max_age, timedelta):
4647
max_age = max_age.total_seconds()

rest/tests/test_rest_service.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -592,7 +592,7 @@ def fancy_get_time():
592592
data = json.loads(results.data)
593593
self.assertEquals(data, d)
594594
self.assertEquals(results.status_code, 200)
595-
self.assertFalse(self.rest_service.uuids.has_key('key'))
595+
self.assertFalse('key' in self.rest_service.uuids)
596596

597597

598598
# test with uuid, no response
@@ -612,7 +612,7 @@ def fancy_get_time2():
612612
data = json.loads(results.data)
613613
self.assertEquals(data, d)
614614
self.assertEquals(results.status_code, 200)
615-
self.assertTrue(self.rest_service.uuids.has_key('key'))
615+
self.assertTrue('key' in self.rest_service.uuids)
616616
self.assertEquals(self.rest_service.uuids['key'], 'poll')
617617

618618
def test_poll(self):

0 commit comments

Comments
 (0)