-
Notifications
You must be signed in to change notification settings - Fork 562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the common files. #1020
Merged
Merged
Update the common files. #1020
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| a9d5cc326ae26ee31b71daa518d9a71992f2c30b | ||
| a1b90298cbd53a7cd6659becb163a1d559e99daa |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,339 +1,52 @@ | ||
| all: generate | ||
|
|
||
| ######################## | ||
| # setup | ||
| ######################## | ||
|
|
||
| apitools_img := gcr.io/istio-testing/api-build-tools:2019-07-31 | ||
| websitetools_img := gcr.io/istio-testing/website-tools:2019-07-25 | ||
| cue_img := gcr.io/istio-testing/cue:2019-07-23 | ||
| pwd := $(shell pwd) | ||
| mount_dir := /src | ||
| repo_dir := istio.io/api | ||
| repo_mount := $(mount_dir)/istio.io/api | ||
| out_path = . | ||
| uid := $(shell id -u) | ||
|
|
||
| protoc = docker run --user $(uid) -v /etc/passwd:/etc/passwd:ro --rm -v $(pwd):$(repo_mount) -w $(mount_dir) $(apitools_img) protoc -I/usr/include/protobuf -I$(repo_dir) | ||
|
|
||
| run = docker run --user $(uid) -v /etc/passwd:/etc/passwd:ro --rm -v $(pwd):$(repo_mount) -w $(repo_mount) $(apitools_img) | ||
| protolock = $(run) protolock | ||
| protolock_release = $(run) /bin/bash $(repo_mount)/scripts/check-release-locks.sh | ||
| prototool = $(run) prototool | ||
| annotations_prep = $(run) annotations_prep | ||
|
|
||
| htmlproofer = docker run --user $(uid) -v /etc/passwd:/etc/passwd:ro --rm -v $(pwd):$(repo_mount) -w $(mount_dir) $(websitetools_img) htmlproofer | ||
|
|
||
| cue = docker run --rm --user $(uid) -v /etc/passwd:/etc/passwd:ro -v $(pwd):$(repo_mount) -w $(mount_dir) $(cue_img) | ||
|
|
||
| ######################## | ||
| # protoc_gen_gogo* | ||
| ######################## | ||
|
|
||
| gogofast_plugin_prefix := --gogofast_out=plugins=grpc, | ||
| gogoslick_plugin_prefix := --gogoslick_out=plugins=grpc, | ||
|
|
||
| comma := , | ||
| empty := | ||
| space := $(empty) $(empty) | ||
|
|
||
| importmaps := \ | ||
| gogoproto/gogo.proto=github.com/gogo/protobuf/gogoproto \ | ||
| google/protobuf/any.proto=github.com/gogo/protobuf/types \ | ||
| google/protobuf/descriptor.proto=github.com/gogo/protobuf/protoc-gen-gogo/descriptor \ | ||
| google/protobuf/duration.proto=github.com/gogo/protobuf/types \ | ||
| google/protobuf/struct.proto=github.com/gogo/protobuf/types \ | ||
| google/protobuf/timestamp.proto=github.com/gogo/protobuf/types \ | ||
| google/protobuf/wrappers.proto=github.com/gogo/protobuf/types \ | ||
| google/rpc/status.proto=istio.io/gogo-genproto/googleapis/google/rpc \ | ||
| google/rpc/code.proto=istio.io/gogo-genproto/googleapis/google/rpc \ | ||
| google/rpc/error_details.proto=istio.io/gogo-genproto/googleapis/google/rpc \ | ||
|
|
||
| # generate mapping directive with M<proto>:<go pkg>, format for each proto file | ||
| mapping_with_spaces := $(foreach map,$(importmaps),M$(map),) | ||
| gogo_mapping := $(subst $(space),$(empty),$(mapping_with_spaces)) | ||
|
|
||
| gogofast_plugin := $(gogofast_plugin_prefix)$(gogo_mapping):$(out_path) | ||
| gogoslick_plugin := $(gogoslick_plugin_prefix)$(gogo_mapping):$(out_path) | ||
|
|
||
| ######################## | ||
| # protoc_gen_python | ||
| ######################## | ||
|
|
||
| python_output_path := python/istio_api | ||
| protoc_gen_python_prefix := --python_out=, | ||
| protoc_gen_python_plugin := $(protoc_gen_python_prefix):$(repo_dir)/$(python_output_path) | ||
|
|
||
| ######################## | ||
| # protoc_gen_docs | ||
| ######################## | ||
|
|
||
| protoc_gen_docs_plugin := --docs_out=warnings=true,dictionary=$(repo_dir)/dictionaries/en-US,custom_word_list=$(repo_dir)/dictionaries/custom.txt,mode=html_fragment_with_front_matter:$(repo_dir)/ | ||
| protoc_gen_docs_plugin_for_networking := --docs_out=warnings=true,dictionary=$(repo_dir)/dictionaries/en-US,custom_word_list=$(repo_dir)/dictionaries/custom.txt,per_file=true,mode=html_fragment_with_front_matter:$(repo_dir)/ | ||
|
|
||
| ##################### | ||
| # Generation Rules | ||
| ##################### | ||
|
|
||
| generate: \ | ||
| generate-mcp \ | ||
| generate-mesh \ | ||
| generate-mixer \ | ||
| generate-networking \ | ||
| generate-rbac \ | ||
| generate-authn \ | ||
| generate-envoy \ | ||
| generate-policy \ | ||
| generate-annotations \ | ||
| generate-openapi-schema | ||
|
|
||
| ##################### | ||
| # mcp/... | ||
| ##################### | ||
|
|
||
| mcp_v1alpha1_path := mcp/v1alpha1 | ||
| mcp_v1alpha1_protos := $(wildcard $(mcp_v1alpha1_path)/*.proto) | ||
| mcp_v1alpha1_pb_gos := $(mcp_v1alpha1_protos:.proto=.pb.go) | ||
| mcp_v1alpha1_pb_pythons := $(patsubst $(mcp_v1alpha1_path)/%.proto,$(python_output_path)/$(mcp_v1alpha1_path)/%_pb2.py,$(mcp_v1alpha1_protos)) | ||
| config_mcp_openapi := $(config_mcp_path)/istio.mcp.v1alpha1.json | ||
|
|
||
| $(mcp_v1alpha1_pb_gos) $(mcp_v1alpha1_pb_pythons): $(mcp_v1alpha1_protos) | ||
| @$(protolock) status | ||
| @$(protoc) $(gogofast_plugin) $(protoc_gen_python_plugin) $^ | ||
|
|
||
| generate-mcp: $(mcp_v1alpha1_pb_gos) $(mcp_v1alpha1_pb_doc) $(mcp_v1alpha1_pb_pythons) | ||
|
|
||
| clean-mcp: | ||
| @rm -fr $(mcp_v1alpha1_pb_gos) $(mcp_v1alpha1_pb_pythons) $(config_mcp_openapi) | ||
|
|
||
| ##################### | ||
| # mesh/... | ||
| ##################### | ||
|
|
||
| mesh_v1alpha1_path := mesh/v1alpha1 | ||
| mesh_v1alpha1_protos := $(wildcard $(mesh_v1alpha1_path)/*.proto) | ||
| mesh_v1alpha1_pb_gos := $(mesh_v1alpha1_protos:.proto=.pb.go) | ||
| mesh_v1alpha1_pb_pythons := $(patsubst $(mesh_v1alpha1_path)/%.proto,$(python_output_path)/$(mesh_v1alpha1_path)/%_pb2.py,$(mesh_v1alpha1_protos)) | ||
| mesh_v1alpha1_pb_doc := $(mesh_v1alpha1_path)/istio.mesh.v1alpha1.pb.html | ||
| mesh_openapi := $(mesh_path)/istio.mesh.v1alpha1.json | ||
|
|
||
| $(mesh_v1alpha1_pb_gos) $(mesh_v1alpha1_pb_doc) $(mesh_v1alpha1_pb_pythons): $(mesh_v1alpha1_protos) | ||
| @$(protolock) status | ||
| @$(protoc) $(gogofast_plugin) $(protoc_gen_docs_plugin)$(mesh_v1alpha1_path) $(protoc_gen_python_plugin) $^ | ||
|
|
||
| generate-mesh: $(mesh_v1alpha1_pb_gos) $(mesh_v1alpha1_pb_doc) $(mesh_v1alpha1_pb_pythons) | ||
|
|
||
| clean-mesh: | ||
| @rm -fr $(mesh_v1alpha1_pb_gos) $(mesh_v1alpha1_pb_doc) $(mesh_v1alpha1_pb_pythons) $(mesh_openapi) | ||
|
|
||
| ##################### | ||
| # policy/... | ||
| ##################### | ||
|
|
||
| policy_v1beta1_path := policy/v1beta1 | ||
| policy_v1beta1_protos := $(wildcard $(policy_v1beta1_path)/*.proto) | ||
| policy_v1beta1_pb_gos := $(policy_v1beta1_protos:.proto=.pb.go) | ||
| policy_v1beta1_pb_pythons := $(patsubst $(policy_v1beta1_path)/%.proto,$(python_output_path)/$(policy_v1beta1_path)/%_pb2.py,$(policy_v1beta1_protos)) | ||
| policy_v1beta1_pb_doc := $(policy_v1beta1_path)/istio.policy.v1beta1.pb.html | ||
| policy_v1beta1_openapi := $(policy_v1beta1_path)/istio.policy.v1beta1.json | ||
|
|
||
| $(policy_v1beta1_pb_gos) $(policy_v1beta1_pb_doc) $(policy_v1beta1_pb_pythons): $(policy_v1beta1_protos) | ||
| @$(protolock) status | ||
| @$(protoc) $(gogoslick_plugin) $(protoc_gen_docs_plugin)$(policy_v1beta1_path) $(protoc_gen_python_plugin) $^ | ||
|
|
||
| generate-policy: $(policy_v1beta1_pb_gos) $(policy_v1beta1_pb_doc) $(policy_v1beta1_pb_pythons) | ||
|
|
||
| clean-policy: | ||
| @rm -fr $(policy_v1beta1_pb_gos) policy/v1beta1/fixed_cfg.pb.go $(policy_v1beta1_pb_doc) $(policy_v1beta1_pb_pythons) $(policy_v1beta1_openapi) | ||
|
|
||
| ##################### | ||
| # mixer/... | ||
| ##################### | ||
|
|
||
| mixer_v1_path := mixer/v1 | ||
| mixer_v1_protos := $(wildcard $(mixer_v1_path)/*.proto) | ||
| mixer_v1_pb_gos := $(mixer_v1_protos:.proto=.pb.go) | ||
| mixer_v1_pb_pythons := $(patsubst $(mixer_v1_path)/%.proto,$(python_output_path)/$(mixer_v1_path)/%_pb2.py,$(mixer_v1_protos)) | ||
| mixer_v1_openapi := $(mixer_v1_path)/istio.mixer.v1.json | ||
|
|
||
| mixer_config_client_path := mixer/v1/config/client | ||
| mixer_config_client_protos := $(wildcard $(mixer_config_client_path)/*.proto) | ||
| mixer_config_client_pb_gos := $(mixer_config_client_protos:.proto=.pb.go) | ||
| mixer_config_client_pb_pythons := $(patsubst $(mixer_config_client_path)/%.proto,$(python_output_path)/$(mixer_client_config_path)/%_pb2.py,$(mixer_client_config_protos)) | ||
| mixer_config_client_pb_doc := $(mixer_config_client_path)/istio.mixer.v1.config.client.pb.html | ||
| mixer_config_client_openapi := $(mixer_config_client_path)/istio.mixer.v1.config.client.json | ||
|
|
||
| mixer_adapter_model_v1beta1_path := mixer/adapter/model/v1beta1 | ||
| mixer_adapter_model_v1beta1_protos := $(wildcard $(mixer_adapter_model_v1beta1_path)/*.proto) | ||
| mixer_adapter_model_v1beta1_pb_gos := $(mixer_adapter_model_v1beta1_protos:.proto=.pb.go) | ||
| mixer_adapter_model_pb_pythons := $(patsubst $(mixer_adapter_model_path)/%.proto,$(python_output_path)/$(mixer_adapter_model_path)/%_pb2.py,$(mixer_adapter_model_protos)) | ||
| mixer_adapter_model_v1beta1_openapi := $(mixer_adapter_model_v1beta1_path)/istio.mixer.adapter.model.v1beta1.json | ||
|
|
||
| $(mixer_v1_pb_gos) $(mixer_v1_pb_pythons): $(mixer_v1_protos) | ||
| @$(protolock) status | ||
| @$(protoc) $(gogoslick_plugin) $(protoc_gen_python_plugin) $^ | ||
|
|
||
| $(mixer_config_client_pb_gos) $(mixer_config_client_pb_doc) $(mixer_config_client_pb_pythons): $(mixer_config_client_protos) | ||
| @$(protolock) status | ||
| @$(protoc) $(gogoslick_plugin) $(protoc_gen_docs_plugin)$(mixer_config_client_path) $(protoc_gen_python_plugin) $^ | ||
|
|
||
| $(mixer_adapter_model_v1beta1_pb_gos) $(mixer_adapter_model_v1beta1_pb_pythons): $(mixer_adapter_model_v1beta1_protos) | ||
| @$(protolock) status | ||
| @$(protoc) $(gogoslick_plugin) $(protoc_gen_python_plugin) $^ | ||
|
|
||
| generate-mixer: \ | ||
| $(mixer_v1_pb_gos) $(mixer_v1_pb_pythons) \ | ||
| $(mixer_config_client_pb_gos) $(mixer_config_client_pb_doc) $(mixer_config_client_pb_pythons) \ | ||
| $(mixer_adapter_model_v1beta1_pb_gos) $(mixer_adapter_model_v1beta1_pb_pythons) | ||
|
|
||
| clean-mixer: | ||
| @rm -fr $(mixer_v1_pb_gos) $(mixer_v1_pb_pythons) $(mixer_v1_openapi) | ||
| @rm -fr $(mixer_config_client_pb_gos) $(mixer_config_client_pb_doc) $(mixer_config_client_pb_pythons) $(mixer_config_client_openapi) | ||
| @rm -fr $(mixer_adapter_model_v1beta1_pb_gos) $(mixer_adapter_model_v1beta1_pb_pythons) $(mixer_adapter_model_v1beta1_openapi) | ||
|
|
||
| ##################### | ||
| # networking/... | ||
| ##################### | ||
|
|
||
| networking_v1alpha3_path := networking/v1alpha3 | ||
| networking_v1alpha3_protos := $(wildcard $(networking_v1alpha3_path)/*.proto) | ||
| networking_v1alpha3_pb_gos := $(networking_v1alpha3_protos:.proto=.pb.go) | ||
| networking_v1alpha3_pb_pythons := $(patsubst $(networking_v1alpha3_path)/%.proto,$(python_output_path)/$(networking_v1alpha3_path)/%_pb2.py,$(networking_v1alpha3_protos)) | ||
| networking_v1alpha3_pb_docs := $(networking_v1alpha3_protos:.proto=.pb.html) | ||
| networking_v1alpha3_openapi := $(networking_v1alpha3_protos:.proto=.json) | ||
|
|
||
| $(networking_v1alpha3_pb_gos) $(networking_v1alpha3_pb_docs) $(networking_v1alpha3_pb_pythons): $(networking_v1alpha3_protos) | ||
| @$(protolock) status | ||
| @$(protoc) $(gogofast_plugin) $(protoc_gen_docs_plugin_for_networking)$(networking_v1alpha3_path) $(protoc_gen_python_plugin) $^ | ||
|
|
||
| generate-networking: $(networking_v1alpha3_pb_gos) $(networking_v1alpha3_pb_docs) $(networking_v1alpha3_pb_pythons) | ||
|
|
||
| clean-networking: | ||
| @rm -fr $(networking_v1alpha3_pb_gos) $(networking_v1alpha3_pb_docs) $(networking_v1alpha3_pb_pythons) $(networking_v1alpha3_openapi) | ||
|
|
||
| ##################### | ||
| # rbac/... | ||
| ##################### | ||
|
|
||
| rbac_v1alpha1_path := rbac/v1alpha1 | ||
| rbac_v1alpha1_protos := $(wildcard $(rbac_v1alpha1_path)/*.proto) | ||
| rbac_v1alpha1_pb_gos := $(rbac_v1alpha1_protos:.proto=.pb.go) | ||
| rbac_v1alpha1_pb_pythons := $(patsubst $(rbac_v1alpha1_path)/%.proto,$(python_output_path)/$(rbac_v1alpha1_path)/%_pb2.py,$(rbac_v1alpha1_protos)) | ||
| rbac_v1alpha1_pb_doc := $(rbac_v1alpha1_path)/istio.rbac.v1alpha1.pb.html | ||
| rbac_v1alpha1_openapi := $(rbac_v1alpha1_path)/istio.rbac.v1alpha1.json | ||
|
|
||
| $(rbac_v1alpha1_pb_gos) $(rbac_v1alpha1_pb_doc) $(rbac_v1alpha1_pb_pythons): $(rbac_v1alpha1_protos) | ||
| @$(protolock) status | ||
| @$(protoc) $(gogofast_plugin) $(protoc_gen_docs_plugin)$(rbac_v1alpha1_path) $(protoc_gen_python_plugin) $^ | ||
|
|
||
| generate-rbac: $(rbac_v1alpha1_pb_gos) $(rbac_v1alpha1_pb_doc) $(rbac_v1alpha1_protos) | ||
|
|
||
| clean-rbac: | ||
| @rm -fr $(rbac_v1alpha1_pb_gos) $(rbac_v1alpha1_pb_doc) $(rbac_v1alpha1_pb_pythons) $(rbac_v1alpha1_openapi) | ||
|
|
||
| ##################### | ||
| # authentication/... | ||
| ##################### | ||
|
|
||
| authn_v1alpha1_path := authentication/v1alpha1 | ||
| authn_v1alpha1_protos := $(wildcard $(authn_v1alpha1_path)/*.proto) | ||
| authn_v1alpha1_pb_gos := $(authn_v1alpha1_protos:.proto=.pb.go) | ||
| authn_v1alpha1_pb_pythons := $(patsubst $(authn_v1alpha1_path)/%.proto,$(python_output_path)/$(authn_v1alpha1_path)/%_pb2.py,$(authn_v1alpha1_protos)) | ||
| authn_v1alpha1_pb_doc := $(authn_v1alpha1_path)/istio.authentication.v1alpha1.pb.html | ||
| authn_v1alpha1_openapi := $(authn_v1alpha1_path)/istio.authentication.v1alpha1.json | ||
|
|
||
| $(authn_v1alpha1_pb_gos) $(authn_v1alpha1_pb_doc) $(authn_v1alpha1_pb_pythons): $(authn_v1alpha1_protos) | ||
| @$(protolock) status | ||
| @$(protoc) $(gogofast_plugin) $(protoc_gen_docs_plugin)$(authn_v1alpha1_path) $(protoc_gen_python_plugin) $^ | ||
|
|
||
| generate-authn: $(authn_v1alpha1_pb_gos) $(authn_v1alpha1_pb_doc) $(authn_v1alpha1_pb_pythons) | ||
|
|
||
| clean-authn: | ||
| @rm -fr $(authn_v1alpha1_pb_gos) $(authn_v1alpha1_pb_doc) $(authn_v1alpha1_pb_pythons) $(authn_v1alpha1_openapi) | ||
|
|
||
| ##################### | ||
| # envoy/... | ||
| ##################### | ||
|
|
||
| envoy_path := envoy | ||
| envoy_protos := $(shell find $(envoy_path) -type f -name '*.proto' | sort) | ||
| envoy_pb_gos := $(envoy_protos:.proto=.pb.go) | ||
| envoy_pb_pythons := $(patsubst $(envoy_path)/%.proto,$(python_output_path)/$(envoy_path)/%_pb2.py,$(envoy_protos)) | ||
|
|
||
| $(envoy_pb_gos): %.pb.go : %.proto | ||
| @$(protolock) status | ||
| @$(protoc) $(gogofast_plugin) $< | ||
|
|
||
| $(envoy_pb_pythons): $(envoy_protos) | ||
| @$(protolock) status | ||
| @$(protoc) $(protoc_gen_python_plugin) $^ | ||
|
|
||
| generate-envoy: $(envoy_pb_gos) $(envoy_pb_pythons) | ||
|
|
||
| clean-envoy: | ||
| @rm -fr $(envoy_pb_gos) $(envoy_pb_pythons) | ||
|
|
||
| ##################### | ||
| # annotation/... | ||
| ##################### | ||
|
|
||
| annotations_path := annotation | ||
| annotations_pb_go := $(annotations_path)/annotations.gen.go | ||
| annotations_pb_doc := $(annotations_path)/annotations.pb.html | ||
|
|
||
| $(annotations_pb_go) $(annotations_pb_doc): $(annotations_path)/annotations.yaml | ||
| @$(annotations_prep) --input $(annotations_path)/annotations.yaml --output $(annotations_pb_go) --html_output $(annotations_pb_doc) | ||
|
|
||
| generate-annotations: $(annotations_pb_go) $(annotations_pb_doc) | ||
|
|
||
| clean-annotations: | ||
| @rm -fr $(annotations_pb_go) $(annotations_pb_doc) | ||
|
|
||
| ##################### | ||
| # Protolock | ||
| ##################### | ||
|
|
||
| proto-commit: | ||
| @$(protolock) commit | ||
|
|
||
| proto-commit-force: | ||
| @$(protolock) commit --force | ||
|
|
||
| proto-status: | ||
| @$(protolock) status | ||
|
|
||
| release-lock-status: | ||
| @$(protolock_release) | ||
|
|
||
| ##################### | ||
| # Lint | ||
| ##################### | ||
|
|
||
| lint: | ||
| @scripts/check_license.sh | ||
| @$(prototool) lint --protoc-bin-path=/usr/bin/protoc --protoc-wkt-path=/usr/include/protobuf | ||
| @$(htmlproofer) . --url-swap "istio.io:preliminary.istio.io" --assume-extension --check-html --check-external-hash --check-opengraph --timeframe 2d --storage-dir $(repo_dir)/.htmlproofer --url-ignore "/localhost/" | ||
|
|
||
| ##################### | ||
| # OpenAPI Schema | ||
| ##################### | ||
|
|
||
| generate-openapi-schema: | ||
| @$(cue) -f=$(repo_dir)/cue.yaml | ||
|
|
||
| ##################### | ||
| # Cleanup | ||
| ##################### | ||
|
|
||
| clean: \ | ||
| clean-mcp \ | ||
| clean-mesh \ | ||
| clean-mixer \ | ||
| clean-networking \ | ||
| clean-rbac \ | ||
| clean-authn \ | ||
| clean-envoy \ | ||
| clean-policy \ | ||
| clean-annotations | ||
|
|
||
| include Makefile.common.mk | ||
| # WARNING: DO NOT EDIT, THIS FILE IS PROBABLY A COPY | ||
| # | ||
| # The original version of this file is located in the https://github.com/istio/common-files repo. | ||
| # If you're looking at this file in a different repo and want to make a change, please go to the | ||
| # common-files repo, make the change there and check it in. Then come back to this repo and run | ||
| # "make updatecommon". | ||
|
|
||
| # Copyright 2019 Istio Authors | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| RUN = | ||
|
|
||
| # Set the enviornment variable BUILD_WITH_CONTAINER to use a container | ||
| # to build the repo. The only dependencies in this mode are to have make and | ||
| # docker. If you'd rather build with a local tool chain instead, you'll need to | ||
| # figure out all the tools you need in your environment to make that work. | ||
| export BUILD_WITH_CONTAINER ?= 0 | ||
| ifeq ($(BUILD_WITH_CONTAINER),1) | ||
| IMG = gcr.io/istio-testing/build-tools:2019-08-05 | ||
| UID = $(shell id -u) | ||
| PWD = $(shell pwd) | ||
| GOBIN_SOURCE ?= $(GOPATH)/bin | ||
| GOBIN ?= /work/out/bin | ||
|
|
||
| RUN = docker run -t --sig-proxy=true -u $(UID) --rm \ | ||
| -v /etc/passwd:/etc/passwd:ro \ | ||
| -v $(readlink /etc/localtime):/etc/localtime:ro \ | ||
| --mount type=bind,source="$(PWD)",destination="/work" \ | ||
| --mount type=volume,source=istio-go-mod,destination="/go/pkg/mod" \ | ||
| --mount type=volume,source=istio-go-cache,destination="/gocache" \ | ||
| --mount type=bind,source="$(GOBIN_SOURCE)",destination="/go/out/bin" \ | ||
| -w /work $(IMG) | ||
| endif | ||
|
|
||
| MAKE = $(RUN) make -f Makefile.core.mk | ||
|
|
||
| %: | ||
| @$(MAKE) $@ | ||
|
|
||
| default: | ||
| @$(MAKE) | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
planning to transition this repo to the new build system with this pr?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope. Just updating the common files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh build-with-container=0. got it.