Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BoolValueForPB.GetValue not work if BoolValueForPB is nil #1938

Closed
2 tasks done
kebe7jun opened this issue Apr 6, 2021 · 0 comments
Closed
2 tasks done

BoolValueForPB.GetValue not work if BoolValueForPB is nil #1938

kebe7jun opened this issue Apr 6, 2021 · 0 comments

Comments

@kebe7jun
Copy link
Member

kebe7jun commented Apr 6, 2021 •
edited
Loading

Can we remove this? You can just do v.GetValue() which is more clear and already nil-safe

Originally posted by @howardjohn in istio/istio#31892 (comment)

Tasks:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kebe7jun