-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python 3.12 compatibility; docker, venv/virtualenv #1015
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FWIW these changes LGTM, apart from the merge conflicts :) |
In Python 3.12, python -m venv seemingly no longer pulls in pip and setuptools, so switch to virtualenv instead `python setup.py develop` is now even more heavily discouraged, so use `pip install -e` instead
See https://docs.docker.com/compose/compose-file/04-version-and-name/ > The top-level version property is defined by the Compose > Specification for backward compatibility. It is only > informative and you'll receive a warning message that it is > obsolete if used.
N.b. `PYTHON_VERSION` env var is already taken by the underlying Debian image and conflicts when running commands such as pip or virtualenv
Docker hub is implicitly set as registry, make it explicit
This way, the docker image instructions stay consistent with what the docs recommend for regular installations
`python setup.py develop` is discouraged in newer Python versions
ix5
changed the title
[DNM] Python 3.12 compatibility; docker, venv/virtualenv
Python 3.12 compatibility; docker, venv/virtualenv
May 5, 2024
Might also be time to move on from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
CHANGES.rst
because this is a user-facing change or an important bugfixWhat changes does this Pull Request introduce?
Compatibility for Python 3.12 and a few stray nits
virtualenv
package in docs, make pip and virtualenv related commands more consistentsetuptools
insetup.py
(mostly because ofpkg_resources
)Makefile
, remove version fromcompose
file, improveDockerfile
formattingsetup.py
and use it inDockerfile
, GitHub ActionsWhy is this necessary?
Python 3.12 changes: What's new
python -m venv
andvirtualenv
interchangeably in the docspython -m venv
seemingly no longer pulls inpip
andsetuptools
, so switch tovirtualenv
insteadpython setup.py develop
is now even more heavily discouraged