Capture sync async with getBoundingClientRect #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
issackjohn
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR refactors benchmark test code to improve layout synchronization with iframe content by changing how page layout forcing is handled and how iframe elements are accessed.
- Updated all benchmark test steps to pass specific target elements to the
layout()method instead of forcing layout on the entire page - Refactored iframe element access pattern to use
getContentDocument()and explicit element wrapping - Added async/await synchronization points using
requestAnimationFrameandsetTimeoutto ensure layout operations complete
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| resources/tests.mjs | Updated all benchmark test steps to use targeted layout forcing and new iframe access pattern |
| resources/benchmark-runner.mjs | Modified layout() method to accept target parameter and made wrapElement() public |
| experimental/responsive-design/src/lib/components/information-window.js | Removed unnecessary requestUpdate() call |
| experimental/responsive-design/src/lib/components/chat-window.js | Made chat methods async |
| experimental/responsive-design/src/lib/components/chat-input.js | Removed event bubbling properties |
| experimental/responsive-design/src/lib/components/app-ribbon.js | Optimized resize handling to avoid unnecessary updates |
|
@lpardosixtosMs do you mind taking a look at tests.mjs please. |
…e for improved readability
issackjohn
added a commit
that referenced
this pull request
Aug 25, 2025
* Refactor layout method to accept target element for improved flexibility * refactor: simplify layout method by using logical OR for body assignment * refactor: replace magic numbers with named constants for media query breakpoints * refactor: replace repeated calls to getContentDocument with a variable for improved readability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.