Skip to content

Fix an issue with logical replication test and simplify the test #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 12, 2022

Conversation

osaxma
Copy link
Contributor

@osaxma osaxma commented Sep 12, 2022

  • Fixed a string concatenation issue that made the test fail before.
  • updated docker_process in dev_dependencies
  • Simplified the test by adding configurations directly to usePostgresContainer.

On another note, I tried to make the logical replication test work on the CI in my fork but with no success. I could not find a way to pass image arguments to the container in the current setup of dart.yaml. I think a custom container would be needed but maybe that can be done another time.

For reference, mounting a volume with the current setup also wasn't straight forward. Here's the workaround for future reference:

    services:
      postgres:
        .....
        volumes:
         # mounting the volume
          - ${{ github.workspace }}/test/custom_config/postgresql.conf:/etc/postgresql/postgresql.conf
        .....

    steps:
      # This step must be before `checkout`
      # This solves an issue that prevents mounting the volume due to `checkout` cleanup job
      # For more details, see: https://github.com/actions/checkout/issues/211#issuecomment-611986243
      - name: Change owner for workspace to prevent volume mounting issue in checkout action
        run: sudo chown -R $USER:$USER ${{ github.workspace }}

@isoos isoos merged commit 29f945c into isoos:master Sep 12, 2022
@osaxma osaxma deleted the fix_test_issue_logical_rep branch September 16, 2022 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants