Skip to content

Commit f577f87

Browse files
louwersisomorphic-git-bot
authored andcommitted
Remove first person from README.md (#2053)
1 parent 022be83 commit f577f87

File tree

6 files changed

+1181
-1313
lines changed

6 files changed

+1181
-1313
lines changed

js/isomorphic-git/README.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ By providing functionality as individual functions, code bundlers can produce sm
1717
The project includes type definitions so you can enjoy static type-checking and intelligent code completion in editors like VS Code and [CodeSandbox](https://codesandbox.io).
1818

1919
## Project status
20-
The original author of the project ([Billie Hilton](https://github.com/wmhilton)) left the project, but the project is still maintained by two volunteers:
20+
The original author of the project ([Billie Hilton](https://github.com/billiegoose)) left the project, but the project is still maintained by two volunteers:
2121

2222
* [@jcubic](https://github.com/jcubic) (most active)
2323
* [@mojavelinux](https://github.com/mojavelinux)
@@ -114,14 +114,14 @@ Unfortunately, due to the same-origin policy by default `isomorphic-git` can onl
114114
For this purpose [@isomorphic-git/cors-proxy](https://github.com/isomorphic-git/cors-proxy) exists which you can clone or [`npm install`](https://www.npmjs.com/package/@isomorphic-git/cors-proxy).
115115
For testing or small projects, you can also use [https://cors.isomorphic-git.org](https://cors.isomorphic-git.org) - a free proxy sponsored by [Clever Cloud](https://www.clever-cloud.com/?utm_source=ref&utm_medium=link&utm_campaign=isomorphic-git).
116116

117-
I'm hoping to get CORS headers added to all the major Git hosting platforms eventually, and will list my progress here:
117+
We hope to get CORS headers added to all the major Git hosting platforms eventually, and will list the progress made here:
118118

119119
| Service | Supports CORS requests |
120120
| ------------------- | ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
121121
| Gogs (self-hosted) | [](https://isomorphic-git.github.io/blog/2018/04/07/gogs-adds-cors-headers-for-isomorphic-git.html) |
122122
| Gitea (self-hosted) | [](https://github.com/go-gitea/gitea/pull/5719) |
123123
| Azure DevOps | [](https://github.com/isomorphic-git/isomorphic-git/issues/678#issuecomment-452402740) (Usage Note: requires authentication) |
124-
| Gitlab |My [PR](https://gitlab.com/gitlab-org/gitlab-workhorse/merge_requests/219) was rejected, but the [issue](https://gitlab.com/gitlab-org/gitlab/issues/20590) is still open! |
124+
| Gitlab |Our [PR](https://gitlab.com/gitlab-org/gitlab-workhorse/merge_requests/219) was rejected, but the [issue](https://gitlab.com/gitlab-org/gitlab/issues/20590) is still open! |
125125
| Bitbucket ||
126126
| Github ||
127127

@@ -140,7 +140,7 @@ The CLI is more of a lark for quickly testing `isomorphic-git` and isn't really
140140

141141
## Supported Git commands
142142

143-
This project follows semantic versioning, so I may continue to make changes to the API but they will always be backwards compatible
143+
This project follows semantic versioning, so we may continue to make changes to the API but they will always be backwards compatible
144144
unless there is a major version bump.
145145

146146
### commands
@@ -267,7 +267,7 @@ Check out the [`CONTRIBUTING`](./CONTRIBUTING.md) document for more instructions
267267

268268
Isomorphic-git would not have been possible without the pioneering work by
269269
@creationix and @chrisdickinson. Git is a tricky binary mess, and without
270-
their examples (and their modules!) I would not have been able to come even
270+
their examples (and their modules!) we would not have been able to come even
271271
close to finishing this. They are geniuses ahead of their time.
272272

273273
Cross-browser device testing is provided by:

js/isomorphic-git/http/node/index.d.ts

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -13,29 +13,29 @@ export type GitHttpRequest = {
1313
/**
1414
* - The HTTP method to use
1515
*/
16-
method?: string;
16+
method?: string | undefined;
1717
/**
1818
* - Headers to include in the HTTP request
1919
*/
2020
headers?: {
2121
[x: string]: string;
22-
};
22+
} | undefined;
2323
/**
2424
* - An HTTP or HTTPS agent that manages connections for the HTTP client (Node.js only)
2525
*/
2626
agent?: any;
2727
/**
2828
* - An async iterator of Uint8Arrays that make up the body of POST requests
2929
*/
30-
body?: any;
30+
body?: AsyncIterableIterator<Uint8Array>;
3131
/**
3232
* - Reserved for future use (emitting `GitProgressEvent`s)
3333
*/
34-
onProgress?: ProgressCallback;
34+
onProgress?: ProgressCallback | undefined;
3535
/**
3636
* - Reserved for future use (canceling a request)
3737
*/
38-
signal?: any;
38+
signal?: object;
3939
};
4040
export type GitHttpResponse = {
4141
/**
@@ -45,17 +45,17 @@ export type GitHttpResponse = {
4545
/**
4646
* - The HTTP method that was used
4747
*/
48-
method?: string;
48+
method?: string | undefined;
4949
/**
5050
* - HTTP response headers
5151
*/
5252
headers?: {
5353
[x: string]: string;
54-
};
54+
} | undefined;
5555
/**
5656
* - An async iterator of Uint8Arrays that make up the body of the response
5757
*/
58-
body?: any;
58+
body?: AsyncIterableIterator<Uint8Array>;
5959
/**
6060
* - The HTTP status code
6161
*/

js/isomorphic-git/http/web/index.d.ts

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -13,29 +13,29 @@ export type GitHttpRequest = {
1313
/**
1414
* - The HTTP method to use
1515
*/
16-
method?: string;
16+
method?: string | undefined;
1717
/**
1818
* - Headers to include in the HTTP request
1919
*/
2020
headers?: {
2121
[x: string]: string;
22-
};
22+
} | undefined;
2323
/**
2424
* - An HTTP or HTTPS agent that manages connections for the HTTP client (Node.js only)
2525
*/
2626
agent?: any;
2727
/**
2828
* - An async iterator of Uint8Arrays that make up the body of POST requests
2929
*/
30-
body?: any;
30+
body?: AsyncIterableIterator<Uint8Array>;
3131
/**
3232
* - Reserved for future use (emitting `GitProgressEvent`s)
3333
*/
34-
onProgress?: ProgressCallback;
34+
onProgress?: ProgressCallback | undefined;
3535
/**
3636
* - Reserved for future use (canceling a request)
3737
*/
38-
signal?: any;
38+
signal?: object;
3939
};
4040
export type GitHttpResponse = {
4141
/**
@@ -45,17 +45,17 @@ export type GitHttpResponse = {
4545
/**
4646
* - The HTTP method that was used
4747
*/
48-
method?: string;
48+
method?: string | undefined;
4949
/**
5050
* - HTTP response headers
5151
*/
5252
headers?: {
5353
[x: string]: string;
54-
};
54+
} | undefined;
5555
/**
5656
* - An async iterator of Uint8Arrays that make up the body of the response
5757
*/
58-
body?: any;
58+
body?: AsyncIterableIterator<Uint8Array>;
5959
/**
6060
* - The HTTP status code
6161
*/

0 commit comments

Comments
 (0)