fix: push tag: do not update remote ref (#1948)

* fix: do not update remote ref when pushing a tag

* doc: update push doc

Author: hhourani27

docs/en/next/push.html

@@ -70,7 +70,7 @@
 <tr><td><a href="./onPrePush">onPrePush</a></td><td>PrePushCallback</td><td>optional pre-push hook callback</td></tr>
 <tr><td>dir</td><td>string</td><td>The <a href="/docs/en/next/dir-vs-gitdir">working tree</a> directory path</td></tr>
 <tr><td><strong>gitdir</strong></td><td>string = join(dir,'.git')</td><td>The <a href="/docs/en/next/dir-vs-gitdir">git directory</a> path</td></tr>
-<tr><td>ref</td><td>string</td><td>Which branch to push. By default this is the currently checked out branch.</td></tr>
+<tr><td>ref</td><td>string</td><td>Which branch or tag to push. By default this is the currently checked out branch.</td></tr>
 <tr><td>url</td><td>string</td><td>The URL of the remote repository. The default is the value set in the git config for that remote.</td></tr>
 <tr><td>remote</td><td>string</td><td>If URL is not specified, determines which remote to use.</td></tr>
 <tr><td>remoteRef</td><td>string</td><td>The name of the receiving branch on the remote. By default this is the configured remote tracking branch.</td></tr>

docs/en/next/push/index.html

@@ -70,7 +70,7 @@
 <tr><td><a href="./onPrePush">onPrePush</a></td><td>PrePushCallback</td><td>optional pre-push hook callback</td></tr>
 <tr><td>dir</td><td>string</td><td>The <a href="/docs/en/next/dir-vs-gitdir">working tree</a> directory path</td></tr>
 <tr><td><strong>gitdir</strong></td><td>string = join(dir,'.git')</td><td>The <a href="/docs/en/next/dir-vs-gitdir">git directory</a> path</td></tr>
-<tr><td>ref</td><td>string</td><td>Which branch to push. By default this is the currently checked out branch.</td></tr>
+<tr><td>ref</td><td>string</td><td>Which branch or tag to push. By default this is the currently checked out branch.</td></tr>
 <tr><td>url</td><td>string</td><td>The URL of the remote repository. The default is the value set in the git config for that remote.</td></tr>
 <tr><td>remote</td><td>string</td><td>If URL is not specified, determines which remote to use.</td></tr>
 <tr><td>remoteRef</td><td>string</td><td>The name of the receiving branch on the remote. By default this is the configured remote tracking branch.</td></tr>

docs/en/push.html

@@ -70,7 +70,7 @@
 <tr><td><a href="./onPrePush">onPrePush</a></td><td>PrePushCallback</td><td>optional pre-push hook callback</td></tr>
 <tr><td>dir</td><td>string</td><td>The <a href="/docs/en/dir-vs-gitdir">working tree</a> directory path</td></tr>
 <tr><td><strong>gitdir</strong></td><td>string = join(dir,'.git')</td><td>The <a href="/docs/en/dir-vs-gitdir">git directory</a> path</td></tr>
-<tr><td>ref</td><td>string</td><td>Which branch to push. By default this is the currently checked out branch.</td></tr>
+<tr><td>ref</td><td>string</td><td>Which branch or tag to push. By default this is the currently checked out branch.</td></tr>
 <tr><td>url</td><td>string</td><td>The URL of the remote repository. The default is the value set in the git config for that remote.</td></tr>
 <tr><td>remote</td><td>string</td><td>If URL is not specified, determines which remote to use.</td></tr>
 <tr><td>remoteRef</td><td>string</td><td>The name of the receiving branch on the remote. By default this is the configured remote tracking branch.</td></tr>

docs/en/push/index.html

@@ -70,7 +70,7 @@
 <tr><td><a href="./onPrePush">onPrePush</a></td><td>PrePushCallback</td><td>optional pre-push hook callback</td></tr>
 <tr><td>dir</td><td>string</td><td>The <a href="/docs/en/dir-vs-gitdir">working tree</a> directory path</td></tr>
 <tr><td><strong>gitdir</strong></td><td>string = join(dir,'.git')</td><td>The <a href="/docs/en/dir-vs-gitdir">git directory</a> path</td></tr>
-<tr><td>ref</td><td>string</td><td>Which branch to push. By default this is the currently checked out branch.</td></tr>
+<tr><td>ref</td><td>string</td><td>Which branch or tag to push. By default this is the currently checked out branch.</td></tr>
 <tr><td>url</td><td>string</td><td>The URL of the remote repository. The default is the value set in the git config for that remote.</td></tr>
 <tr><td>remote</td><td>string</td><td>If URL is not specified, determines which remote to use.</td></tr>
 <tr><td>remoteRef</td><td>string</td><td>The name of the receiving branch on the remote. By default this is the configured remote tracking branch.</td></tr>

js/isomorphic-git/index.cjs

@@ -12473,7 +12473,12 @@ async function _push({
   }
 
   // Update the local copy of the remote ref
-  if (remote && result.ok && result.refs[fullRemoteRef].ok) {
+  if (
+    remote &&
+    result.ok &&
+    result.refs[fullRemoteRef].ok &&
+    !fullRef.startsWith('refs/tags')
+  ) {
     // TODO: I think this should actually be using a refspec transform rather than assuming 'refs/remotes/{remote}'
     const ref = `refs/remotes/${remote}/${fullRemoteRef.replace(
       'refs/heads',
@@ -12520,7 +12525,7 @@ async function _push({
  * @param {PrePushCallback} [args.onPrePush] - optional pre-push hook callback
  * @param {string} [args.dir] - The [working tree](dir-vs-gitdir.md) directory path
  * @param {string} [args.gitdir=join(dir,'.git')] - [required] The [git directory](dir-vs-gitdir.md) path
- * @param {string} [args.ref] - Which branch to push. By default this is the currently checked out branch.
+ * @param {string} [args.ref] - Which branch or tag to push. By default this is the currently checked out branch.
  * @param {string} [args.url] - The URL of the remote repository. The default is the value set in the git config for that remote.
  * @param {string} [args.remote] - If URL is not specified, determines which remote to use.
  * @param {string} [args.remoteRef] - The name of the receiving branch on the remote. By default this is the configured remote tracking branch.

js/isomorphic-git/index.d.ts

@@ -2463,7 +2463,7 @@ export function pull({ fs: _fs, http, onProgress, onMessage, onAuth, onAuthSucce
  * @param {PrePushCallback} [args.onPrePush] - optional pre-push hook callback
  * @param {string} [args.dir] - The [working tree](dir-vs-gitdir.md) directory path
  * @param {string} [args.gitdir=join(dir,'.git')] - [required] The [git directory](dir-vs-gitdir.md) path
- * @param {string} [args.ref] - Which branch to push. By default this is the currently checked out branch.
+ * @param {string} [args.ref] - Which branch or tag to push. By default this is the currently checked out branch.
  * @param {string} [args.url] - The URL of the remote repository. The default is the value set in the git config for that remote.
  * @param {string} [args.remote] - If URL is not specified, determines which remote to use.
  * @param {string} [args.remoteRef] - The name of the receiving branch on the remote. By default this is the configured remote tracking branch.

js/isomorphic-git/index.js

@@ -12467,7 +12467,12 @@ async function _push({
   }
 
   // Update the local copy of the remote ref
-  if (remote && result.ok && result.refs[fullRemoteRef].ok) {
+  if (
+    remote &&
+    result.ok &&
+    result.refs[fullRemoteRef].ok &&
+    !fullRef.startsWith('refs/tags')
+  ) {
     // TODO: I think this should actually be using a refspec transform rather than assuming 'refs/remotes/{remote}'
     const ref = `refs/remotes/${remote}/${fullRemoteRef.replace(
       'refs/heads',
@@ -12514,7 +12519,7 @@ async function _push({
  * @param {PrePushCallback} [args.onPrePush] - optional pre-push hook callback
  * @param {string} [args.dir] - The [working tree](dir-vs-gitdir.md) directory path
  * @param {string} [args.gitdir=join(dir,'.git')] - [required] The [git directory](dir-vs-gitdir.md) path
- * @param {string} [args.ref] - Which branch to push. By default this is the currently checked out branch.
+ * @param {string} [args.ref] - Which branch or tag to push. By default this is the currently checked out branch.
  * @param {string} [args.url] - The URL of the remote repository. The default is the value set in the git config for that remote.
  * @param {string} [args.remote] - If URL is not specified, determines which remote to use.
  * @param {string} [args.remoteRef] - The name of the receiving branch on the remote. By default this is the configured remote tracking branch.

js/isomorphic-git/index.umd.min.d.ts

@@ -2463,7 +2463,7 @@ export function pull({ fs: _fs, http, onProgress, onMessage, onAuth, onAuthSucce
  * @param {PrePushCallback} [args.onPrePush] - optional pre-push hook callback
  * @param {string} [args.dir] - The [working tree](dir-vs-gitdir.md) directory path
  * @param {string} [args.gitdir=join(dir,'.git')] - [required] The [git directory](dir-vs-gitdir.md) path
- * @param {string} [args.ref] - Which branch to push. By default this is the currently checked out branch.
+ * @param {string} [args.ref] - Which branch or tag to push. By default this is the currently checked out branch.
  * @param {string} [args.url] - The URL of the remote repository. The default is the value set in the git config for that remote.
  * @param {string} [args.remote] - If URL is not specified, determines which remote to use.
  * @param {string} [args.remoteRef] - The name of the receiving branch on the remote. By default this is the configured remote tracking branch.