Checking if mouse pointer is exactly over table row (without offset) #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when we drag a row by clicking on the top of the row, the drag class is applied to the next row before mouse pointer is really over this row. Furthermore, when we drag a row by clicking on the bottom of the row, the drag class is applied to the next row some time after mouse pointer crossed border of this row.
Is this behaviour intentional? I thought that in some cases better solution could be to apply the drag class right after the moment when mouse pointer crossed border of the row (not taking into account if the user started dragging at the top or at the bottom of the row). In this pull request i proposed a change which enable to choose between those two behaviours: calculating mouse offset of the initial mouse pointer position (current behaviour) and the second, which I described above.