CMS error: hardcoded CMS icon path does not handle '_resources' folder

[jules0x]

silverstripe-singleobjectadmin/src/SingleObjectAdmin.php

Line 33 in 911cf52

private static $menu_icon = 'resources/vendor/littlegiant/silverstripe-singleobjectadmin/dist/images/singleobjectadmin.png';

[jules0x]

Since SilverStripe 4.4.0 the resources folder can be '_resources' so as to free that URL segment for content pages. This approach is not compulsory, so the path could be either or...

https://docs.silverstripe.org/en/4/changelogs/4.4.0/#adopting-to-new-resources-directory

[jules0x]

I'm able to override the static in yml. Not sure what the approach should be for a PR 🤔

LittleGiant\SingleObjectAdmin\SingleObjectAdmin:
  menu_icon: '_resources/vendor/littlegiant/silverstripe-singleobjectadmin/dist/images/singleobjectadmin.png'

[stevie-mayhew]

@jules0x this should probably be done using the resource loader, and a vendor-expose in the composer.json.

Do you know how to do that - if not I can find some docs or get a PR done for you to review

[RoyalPulp]

Hey there!
isn't it possible to override the default $menu_icon by $menu_icon_class like I would do with other ModelAdmin entries in the menu?
thanks, Hendrik