Decorator some methods to classmethod and staticmethod

Author: lucas-six

django_rq_wrapper/management/commands/rqworkers.py

@@ -47,7 +47,8 @@ def add_arguments(self, parser):
                             dest='worker_ttl', default=420,
                             help='Default worker timeout to be used')
         parser.add_argument('--workers', '-w', action='store', type=int, dest='num_workers',
-                            default=None, help='Number of workers to spawn, defaults to RQ_CONCURRENCY, or 1')
+                            default=None,
+                            help='Number of workers to spawn, defaults to RQ_CONCURRENCY, or 1')
         parser.add_argument('--autoreload', action='store_true', dest='autoreload',
                             default=False, help='Enable autoreload of rqworkers for development')
 
@@ -88,15 +89,21 @@ def handle(self, *args, **options):
             else:
                 self.create_worker(*queues, **options)
 
-    def create_worker_process(self):
+    @staticmethod
+    def create_worker_process():
+        """Create a worker process.
+        """
         args = [sys.executable] + ['-W%s' % o for o in sys.warnoptions] + sys.argv
         if sys.platform == "win32":
             args = ['"%s"' % arg for arg in args]
         new_environ = os.environ.copy()
         new_environ['RUN_MAIN'] = 'true'
         return subprocess.Popen(args, executable=sys.executable, env=new_environ)
 
-    def create_reloader(self, workers):
+    @classmethod
+    def create_reloader(cls, workers):
+        """Create a reloader.
+        """
         args = [sys.executable] + ['-W%s' % o for o in sys.warnoptions] + sys.argv
         if sys.platform == "win32":
             args = ['"%s"' % arg for arg in args]
@@ -111,19 +118,22 @@ def create_reloader(self, workers):
             new_workers = []
             for worker in workers:
                 worker.terminate()
-                new_workers.append(self.create_worker_process())
-            self.create_reloader(new_workers)
+                new_workers.append(cls.create_worker_process())
+            cls.create_reloader(new_workers)
         else:
             for worker in workers:
                 worker.terminate()
             sys.exit(reloader.returncode)
 
-    def create_worker(self, *args, **options):
+    @staticmethod
+    def create_worker(*args, **options):
+        """Create a worker.
+        """
         try:
             # Instantiate a worker
             worker_class = import_attribute(options['worker_class'])
             queues = get_queues(*args, queue_class=import_attribute(options['queue_class']))
-            w = worker_class(
+            worker = worker_class(
                 queues,
                 connection=queues[0].connection,
                 name=options['name'],
@@ -133,7 +143,7 @@ def create_worker(self, *args, **options):
 
             # Call use_connection to push the redis connection into LocalStack
             # without this, jobs using RQ's get_current_job() will fail
-            use_connection(w.connection)
-            w.work(burst=options.get('burst', False))
+            use_connection(worker.connection)
+            worker.work(burst=options.get('burst', False))
         except redis.exceptions.ConnectionError as err:
             logger.error(err)