[pull] main from react-navigation:main #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Safari doesn't seem to support H.265 codec
…rops (#1420) * docs: add deprecation message to some status/navigation bar related props * change bare urls to markdown links
Removed extra space in :::warning syntax in docs/server-rendering.md to enable proper rendering as a highlighted markdown warning block.
Co-authored-by: Satyajit Sahoo <satyajit.happy@gmail.com>
- functionally identical to an old PR of mine in a different repo: argoproj/argo-helm@429b474 - the notes about versioned docs are purely notational, i.e. have nothing to fill out - comment them out with HTML comments, as is common practice - example from a repo I maintain: https://github.com/ezolenko/rollup-plugin-typescript2/blob/f6db59613a66f58c48310aa8fa785951970b5d6d/.github/issue_template.md?plain=1#L2 - I copied that from other repos too - these comments are still visible to the PR author, just not visible when rendered, keeping the PR more concise
- a986dd6 ([this file](a986dd6#diff-63dff0846bfbe2660b99482110780b8d24d4376f99160ddf447ad809b77749ef)) erroneously duplicated links in both sections when one section is "Contributing" and the other is "Information" - this only affected v5-v7. earlier versions [like v4 are correct](https://github.com/react-navigation/react-navigation.github.io/blob/60212e48ae8b2e85d0d2a63a7f2d824750ebd9c2/versioned_docs/version-4.x/contributing.md?plain=1#L9)
* fix(contrib): update links to Issue & PR templates - these were broken / 404'ing - singular issue template was changed to multiple in react-navigation/react-navigation@f705094 and then to issue forms in react-navigation/react-navigation@e479465 - PR template file name was changed / fixed in react-navigation/react-navigation@64ab0f3 * backport to v6 and v5 * fix broken links in v4 as well the [`4.x` branch](https://github.com/react-navigation/react-navigation/tree/4.x) has no issue templates or PR templates, but the latest 4.x tag, [v4.1.1](https://github.com/react-navigation/react-navigation/tree/v4.1.1), does * use `6.x` branch for 6.x docs links - [`6.x` branch](https://github.com/react-navigation/react-navigation/tree/6.x) * use a v5 tag for v5 docs links - `5.x` branch does not have a `.github` directory, so use [`@react-navigation/core@5.14.4` tag](https://github.com/react-navigation/react-navigation/tree/%40react-navigation/core%405.14.4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )