Add default key support to HiveType adapters#724
Open
Conversation
Contributor
|
Thanks for your contribution 😇 However I have a bit of concern about the implementation. Wouldn't adapter lookup when adding new entries affect the speed of writes? For example if you've |
Contributor
Author
|
You're right. |
Contributor
Let's discuss it before implementation. Maybe it's not worth to reduce performance in favour of implementing this feature because users can extend their models from HiveObject to support key fields. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
@janniklind had requested(#578) a feature to add
isKeyfield toHiveFieldannotation and use the field withisKey=trueas default key of that class instances inaddfunction.So I implemented it. Before this, the
addmethod of the base box class was usingkeystore.autoIncrementas default key. Now there's ability for people to set one of that class getters as default key.For example:
and therefore in main function:
It will use 26 as the key of inserted dog.