[Refactor] use more explicit assert.ok

[ljharb]

This is a tiny refactor, hopefully it's acceptable.

(We'll all be much happier if you choose not to ask why i need this change :-) )

[nicolas377]

@isaacs does this need documentation since it's such a small change?

[ljharb]

I'd assume not; virtually nobody but me's going to notice.

[nicolas377]

We'll all be much happier if you choose not to ask why i need this change

@ljharb I'm actually a bit curious why you were running into an issue with this. assert() seems to be an alias of assert.ok(), so what's the issue on the api's end? If changing from assert() from assert.ok() does fix an issue or change functionality even in a very small way, we'll have to document this.

[ljharb]

@nicolas377 see the second sentence in the OP.

In node 0.6+, this will behave identically. Absolutely nothing needs to be documented that affects an older version of node than that :-)

[nicolas377]

@isaacs LGTM! All the functionality this changes is out of scope of this package's supported node versions.

[isaacs]

(We'll all be much happier if you choose not to ask why i need this change :-) )

Oh god, I think I know what's going on here lol 😂

Do you need this backported to v7? v8 is node 12+ already anyway.

[ljharb]

@isaacs ideally yes, but i understand if you're unwilling. either way this drastically reduces the number of n_m patches i need to float :-)

[isaacs]

Published on 7.2.2 and 8.0.3