Skip to content
This repository has been archived by the owner on Nov 18, 2021. It is now read-only.

Diff after a force push should use range-diff, not an absolute diff #1834

Open
jyn514 opened this issue Jul 18, 2020 · 0 comments
Open

Diff after a force push should use range-diff, not an absolute diff #1834

jyn514 opened this issue Jul 18, 2020 · 0 comments

Comments

@jyn514
Copy link

jyn514 commented Jul 18, 2020

Consider for example this force-push: https://github.com/rust-lang/rust/compare/86d182ebd0cf9900f32e1f58addc1fc21f9b791b..f8934505dcde03c1db784bde05b81c926bbc1714

This shows a diff of 1,275 changed files with 20,128 additions and 8,906 deletions. Almost all of these changes were from rebasing over the master branch; finding the changes which aren't related to that is basically impossible. GitHub should instead show a range diff of the changes, which is much more readable:

$ git range-diff 86d182ebd0cf9900f32e1f58addc1fc21f9b791b~..86d182ebd0cf9900f32e1f58addc1fc21f9b791b f8934505dcde03c1db784bde05b81c926bbc1714^..f8934505dcde03c1db784bde05b81c926bbc1714 --
1:  86d182ebd0c = 1:  f8934505dcd Remove liballoc unneeded explicit link

From this you can clearly see there are no changes other than the rebase.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant