Skip to content

Commit d65b92b

Browse files
authored
Merge pull request #1118 from isaacphysics/hotfix/reassign-quiz-recover-warning
Revert invalid group greying in Set Quiz modal
2 parents 66b07c9 + fbbb9b8 commit d65b92b

File tree

1 file changed

+2
-9
lines changed

1 file changed

+2
-9
lines changed

src/app/components/elements/modals/QuizSettingModal.tsx

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ export function QuizSettingModal({quiz, dueDate: initialDueDate, scheduledStartD
8989
});
9090
}
9191

92-
const isAssignmentSetToThisGroup = (group: Item<number>, assignment?: QuizAssignmentDTO) => assignment ? (assignment.quizId === quiz.id && assignment.groupId === group.value && (assignment.dueDate ? assignment.dueDate.valueOf() < Date.now() : true)) : false;
92+
const isAssignmentSetToThisGroup = (group: Item<number>, assignment?: QuizAssignmentDTO) => assignment ? (assignment.quizId === quiz.id && assignment.groupId === group.value && (assignment.dueDate ? assignment.dueDate.valueOf() > Date.now() : true)) : false;
9393
const alreadyAssignedToAGroup = selectedGroups.some(group => quizAssignments?.some(assignment => isAssignmentSetToThisGroup(group, assignment)));
9494

9595
const groupInvalid = validated.has('group') && selectedGroups.length === 0 || alreadyAssignedToAGroup;
@@ -105,10 +105,7 @@ export function QuizSettingModal({quiz, dueDate: initialDueDate, scheduledStartD
105105
query={groupsQuery}
106106
defaultErrorTitle={"Error fetching groups"}
107107
thenRender={groups => {
108-
function appGroupToItem(g: AppGroup): Item<number> {return {label: g.groupName as string, value: g.id as number}; }
109-
function quizToAssignment(g: AppGroup): QuizAssignmentDTO | undefined { return quizAssignments?.find(assignment => assignment.quizId === quiz.id && assignment.groupId === g.id); }
110-
111-
const groupOptions = groups.map((g: AppGroup) => ({...appGroupToItem(g), isDisabled: isAssignmentSetToThisGroup(appGroupToItem(g), quizToAssignment(g))}));
108+
const groupOptions = groups.map((g: AppGroup) => {return {label: g.groupName as string, value: g.id as number}; });
112109

113110
return <StyledSelect isMulti placeholder="Select groups"
114111
options={groupOptions}
@@ -121,10 +118,6 @@ export function QuizSettingModal({quiz, dueDate: initialDueDate, scheduledStartD
121118
isSearchable
122119
menuPortalTarget={document.body}
123120
styles={{
124-
option: (base, selectProps) => ({
125-
...base,
126-
backgroundColor: selectProps.isFocused && selectProps.isDisabled ? 'transparent' : base.backgroundColor
127-
}),
128121
control: (styles) => ({...styles, ...(groupInvalid ? {borderColor: '#dc3545'} : {})}),
129122
menuPortal: base => ({...base, zIndex: 9999}),
130123
}}

0 commit comments

Comments
 (0)