Adds test for camera to check that different image sizes work #964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pascal-roth
requested review from
Dhoeller19,
Mayankm96,
jsmith-bdai and
kellyguo11
as code owners
Mayankm96
reviewed
Sep 9, 2024
Mayankm96
approved these changes
Sep 9, 2024
Co-authored-by: Mayank Mittal <12863862+Mayankm96@users.noreply.github.com> Signed-off-by: Pascal Roth <57946385+pascal-roth@users.noreply.github.com>
…nto test/diff-img-sizes
|
@Mayankm96 I split up the test, should be ready to be merged now |
Mayankm96
reviewed
Sep 12, 2024
Mayankm96
reviewed
Sep 12, 2024
Signed-off-by: Mayank Mittal <12863862+Mayankm96@users.noreply.github.com>
Mayankm96
approved these changes
Sep 12, 2024
There was a problem hiding this comment.
@kellyguo11 we should add a similar test for the tiled camera too. Tagging you for vis :)
Mayankm96
changed the title
jsmith-bdai
reviewed
Sep 17, 2024
jsmith-bdai
reviewed
Sep 17, 2024
Co-authored-by: James Smith <142246516+jsmith-bdai@users.noreply.github.com> Signed-off-by: Pascal Roth <57946385+pascal-roth@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds test to check that different image sizes are respected by the camera implementation.
Fixes #165
Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there