-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds function to define camera configs through intrinsic matrix #617
Conversation
@Mayankm96 I remember there were issues when the horizontal and vertical apertures differed for the USD camera case. Do you know if that has been resolved by now? Just from looking at the resulting image, I couldn't see something wrong, but otherwise, I will check again. |
source/extensions/omni.isaac.lab/omni/isaac/lab/sensors/ray_caster/patterns/patterns_cfg.py
Outdated
Show resolved
Hide resolved
source/extensions/omni.isaac.lab_assets/omni/isaac/lab_assets/stereolabs.py
Outdated
Show resolved
Hide resolved
source/extensions/omni.isaac.lab_assets/omni/isaac/lab_assets/stereolabs.py
Outdated
Show resolved
Hide resolved
source/extensions/omni.isaac.lab/omni/isaac/lab/sensors/camera/camera.py
Outdated
Show resolved
Hide resolved
source/extensions/omni.isaac.lab/omni/isaac/lab/sensors/camera/camera.py
Show resolved
Hide resolved
source/extensions/omni.isaac.lab/omni/isaac/lab/sensors/ray_caster/patterns/patterns_cfg.py
Outdated
Show resolved
Hide resolved
source/extensions/omni.isaac.lab/omni/isaac/lab/sensors/ray_caster/patterns/patterns_cfg.py
Outdated
Show resolved
Hide resolved
source/extensions/omni.isaac.lab/omni/isaac/lab/sim/spawners/sensors/sensors_cfg.py
Outdated
Show resolved
Hide resolved
source/extensions/omni.isaac.lab/omni/isaac/lab/sim/spawners/sensors/sensors_cfg.py
Outdated
Show resolved
Hide resolved
source/extensions/omni.isaac.lab_assets/omni/isaac/lab_assets/stereolabs.py
Outdated
Show resolved
Hide resolved
source/extensions/omni.isaac.lab_assets/omni/isaac/lab_assets/stereolabs.py
Outdated
Show resolved
Hide resolved
source/extensions/omni.isaac.lab_assets/omni/isaac/lab_assets/stereolabs.py
Outdated
Show resolved
Hide resolved
source/extensions/omni.isaac.lab_assets/omni/isaac/lab_assets/stereolabs.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Mayank Mittal <12863862+Mayankm96@users.noreply.github.com> Signed-off-by: Pascal Roth <57946385+pascal-roth@users.noreply.github.com>
…sim/IsaacLab into feature/cam-init-intrinsic-matrix
I enabled that we can set the vertical aperture, mainly because if we change the horizontal aperture in the USD camera case, the vertical one would always stay at the default value of 15. Weirdly, the offsets seem to make a difference for both cameras but at a very different scale. I added a test to the raycaster camera that initializes both cameras with the same intrinsic matrix. If the offsets are enabled the values changes as follows: offsets equal to 0
offsets unequal 0
@Dhoeller19 and @Mayankm96, do you know how the offsets are handled internally for the USD camera? IMO we handle them correctly for the raycaster case, so that I added warnings now in the USD camera that these values are basically ignored |
…sim/IsaacLab into feature/cam-init-intrinsic-matrix
The tiled camera seems to handle the intrinsics wrong. We are running the same function in the background to assign the values to the USDCamera, but the results do not match. I added a test for it in the |
also would be great to get some reviews here, as more PR depends on this one @Mayankm96 @jsmith-bdai and @Dhoeller19 |
Thanks for adding the tiled rendering test! Perhaps it may be due to that tiled rendering and multi-render product rendering are using different renderers at the moment. Let's test again with the new tiled rendering. Also, looks like test_spawn_sensors.py test is failing |
You're correct, the test was failing. Fixed it now. |
…sim/IsaacLab into feature/cam-init-intrinsic-matrix
…sim/IsaacLab into feature/cam-init-intrinsic-matrix
…c-sim#617) # Description This PR adds the possibility of initializing cameras (both Raycaster Cameras and USD Cameras) with the intrinsic matrix instead of using the aperture parameters. The intrinsic matrix is defined in the pattern config and the pinhole cameras spawn config, respectively. Moreover, it fixes the bug that the vertical aperture is not adjusted for the USD camera case (it will always stay at the default value, even if the horizontal aperture is set). The default is squared pixels; however, it also allows the setting of other values. Fixes isaac-orbit/IsaacLab#226 ## Type of change - New feature (non-breaking change which adds functionality) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
…es the default (#891) # Description This PR adds an option to define the clipping behavior for depth images generated by `RayCasterCamera` and `Camera`. In addition, it unifies the clipping behavior for the depth images of all camera implementations. Per default, all values exceeding the range are clipped to zero for both `distance_to_image_plane` and `distance_to_camera` depth images. Prev. `RayCasterCamera` clipped the values to the maximum value of the depth image, `Camera` did not clip them and had a different behavior for both types, and `TiledCamera` clipped the values to zero. Needs PR #617 to be merged ## Type of change - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there --------- Signed-off-by: Pascal Roth <57946385+pascal-roth@users.noreply.github.com> Signed-off-by: Kelly Guo <kellyg@nvidia.com> Co-authored-by: Mayank Mittal <12863862+Mayankm96@users.noreply.github.com> Co-authored-by: David Hoeller <dhoeller@nvidia.com> Co-authored-by: Kelly Guo <kellyg@nvidia.com> Co-authored-by: Kelly Guo <kellyguo123@hotmail.com>
Description
This PR adds the possibility of initializing cameras (both Raycaster Cameras and USD Cameras) with the intrinsic matrix instead of using the aperture parameters. The intrinsic matrix is defined in the pattern config and the pinhole cameras spawn config, respectively.
Moreover, it fixes the bug that the vertical aperture is not adjusted for the USD camera case (it will always stay at the default value, even if the horizontal aperture is set). The default is squared pixels; however, it also allows the setting of other values.
Fixes https://github.com/isaac-orbit/IsaacLab/issues/226
Type of change
Checklist
pre-commit
checks with./isaaclab.sh --format
config/extension.toml
fileCONTRIBUTORS.md
or my name already exists there