Skip to content

Conversation

zehao-wang
Copy link

@zehao-wang zehao-wang commented Sep 25, 2025

Description

The collision approximation configuration changed in main branch, but the code in tools/convert_mesh.py does not sync.

Fixes #3557

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read and understood the contribution guidelines
  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

Signed-off-by: zehao-wang <59912787+zehao-wang@users.noreply.github.com>
@github-actions github-actions bot added the isaac-lab Related to Isaac Lab team label Sep 25, 2025
Signed-off-by: zehao-wang <59912787+zehao-wang@users.noreply.github.com>
@zehao-wang zehao-wang changed the title Fix bugs: change of mesh collision configuration strategy in v2.2.0 Fix bugs: change of mesh collision configuration strategy in main branch Sep 25, 2025
@Mayankm96 Mayankm96 changed the title Fix bugs: change of mesh collision configuration strategy in main branch Configures mesh collision strategy in convert_mesh.py Oct 10, 2025
Copy link
Contributor

@Mayankm96 Mayankm96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to raise an error if none of the types match (and also avoiding a dangling if-else). Also please run the pre-commit formatter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

isaac-lab Related to Isaac Lab team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug Report] no argument collision_approximation in isaaclab 2.2.0 MeshConverterCfg

2 participants