Adds ability to set platform height independent of object height for terrain #2695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James Tigue <166445701+jtigue-bdai@users.noreply.github.com>
|
having consistent mesh terrain height for repeatedObjects seems to be a nice feature. |
ooctipus
approved these changes
Jul 7, 2025
There was a problem hiding this comment.
Looks good to me, if you have an easy example or modify existing example where platform_height is more appropriate than object height that you can show the intended use case that will be great(let me know if you need help :D). If that's not easy I think this code is good to go!
Main issue is that the starting platform would be required to be the same height as the objects. This allows for them to be decoupled. |
Signed-off-by: Kelly Guo <kellyg@nvidia.com>
harry-wf-cheung
pushed a commit
to harry-wf-cheung/IsaacLab-Harry
that referenced
this pull request
Jul 30, 2025
…terrain (isaac-sim#2695) # Description Allow to set platform height independent of the object height. <!-- As a practice, it is recommended to open an issue to have discussions on the proposed pull request. This makes it easier for the community to keep track of what is being developed or added, and if a given feature is demanded by more than one party. --> ## Type of change - New feature (non-breaking change which adds functionality) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there Credit: @fjenelten-bdai --------- Signed-off-by: James Tigue <166445701+jtigue-bdai@users.noreply.github.com> Signed-off-by: Kelly Guo <kellyg@nvidia.com> Co-authored-by: Kelly Guo <kellyg@nvidia.com>
StephenWelch
pushed a commit
to StephenWelch/IsaacLab
that referenced
this pull request
Aug 17, 2025
…terrain (isaac-sim#2695) # Description Allow to set platform height independent of the object height. <!-- As a practice, it is recommended to open an issue to have discussions on the proposed pull request. This makes it easier for the community to keep track of what is being developed or added, and if a given feature is demanded by more than one party. --> ## Type of change - New feature (non-breaking change which adds functionality) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there Credit: @fjenelten-bdai --------- Signed-off-by: James Tigue <166445701+jtigue-bdai@users.noreply.github.com> Signed-off-by: Kelly Guo <kellyg@nvidia.com> Co-authored-by: Kelly Guo <kellyg@nvidia.com>
4 tasks
6 tasks
Mayankm96
added a commit
that referenced
this pull request
Sep 4, 2025
…ration (#3316) # Description This PR fixes a bug where the platform_height parameter was incorrectly placed in the MeshPyramidStairsTerrainCfg class instead of the appropriate base configuration class for mesh terrain objects. - Removes the misplaced `platform_height` parameter from `MeshPyramidStairsTerrainCfg` - Adds the `platform_height` parameter to the correct location in the `MeshRepeatedObjectsTerrainCfg` class - Includes various formatting improvements with additional blank lines for consistency Fixes #3162 Regression was introduced in MR #2695 ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow to set platform height independent of the object height.
Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists thereCredit: @fjenelten-bdai