Updates locomotion configs to fix body_com error #2655
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kellyguo11
requested review from
Mayankm96,
jsmith-bdai and
jtigue-bdai
as code owners
jtigue-bdai
approved these changes
Jun 11, 2025
| @@ -380,5 +380,3 @@ def __post_init__(self) -> None: | |||
| # disable randomization for play | |||
| self.observations.policy.enable_corruption = False | |||
| # remove random pushing event | |||
| # self.events.base_external_force_torque = None | |||
| # self.events.push_robot = None | |||
There was a problem hiding this comment.
did you mean to delete this line too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The body_com event term added to the base velocity cfg caused errors in some locomotion environments if the body was not named "base". This PR disables the event term for these environments.
Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there