done #3755
Closed
done #3755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xThales
reviewed
Apr 14, 2023
|
|
||
|
|
||
|
|
||
| // Iteration #2: Find longest word | ||
| const words = ['mystery', 'brother', 'aviator', 'crocodile', 'pearl', 'orchard', 'crackpot']; | ||
| function findLongestWord(words) { | ||
| if (words.length == 0) { |
There was a problem hiding this comment.
if (words.length === 0) mejor. Utiliza el operador "===" mejor.
Mejor incluso => if (!words.length)
| if (words.length == 0) { | ||
| return null | ||
| } | ||
| let notLargest = "" |
There was a problem hiding this comment.
longestWord sería un mejor nombre para esta variable. Al fin y al cabo, se trata precisamente de la palabra más larga. notLargest es precisamente lo contrario :<
Comment on lines
+55
to
+63
| for (let i = 0; i < numbers.length; i++) { | ||
| if (typeof numbers[i] === String) { | ||
| return sumOfNumbersAndOthers += numbers[i] | ||
| } | ||
| if (typeof numbers[i] === Number) { | ||
| return sumOfNumbersAndOthers += numbers.length | ||
| } | ||
| if (typeof numbers[i] === Boolean) { | ||
| } |
There was a problem hiding this comment.
typeof devuelve una string. typeof 5 === "number"
Así que estos condicionales nunca van a cumplirse :(
if (typeof numbers[i] === "string") sería correcto en vez de if (typeof numbers[i] === String)
| if (wordsFind.length == 0) { | ||
| return null; | ||
| } | ||
| return wordsFind.includes(wordToSearch) |
|
Gracias Dan!
El vie., 14 abr. 2023 16:11, Daniel Jimenez ***@***.***>
escribió:
… ***@***.**** commented on this pull request.
Buen trabajo! Te dejo unos cuantos comentarios del lab
------------------------------
In src/functions-and-arrays.js
<#3755 (comment)>
:
>
// Iteration #2: Find longest word
const words = ['mystery', 'brother', 'aviator', 'crocodile', 'pearl', 'orchard', 'crackpot'];
+function findLongestWord(words) {
+ if (words.length == 0) {
if (words.length === 0) mejor. Utiliza el operador "===" mejor.
Mejor incluso => if (!words.length)
------------------------------
In src/functions-and-arrays.js
<#3755 (comment)>
:
>
// Iteration #2: Find longest word
const words = ['mystery', 'brother', 'aviator', 'crocodile', 'pearl', 'orchard', 'crackpot'];
+function findLongestWord(words) {
+ if (words.length == 0) {
+ return null
+ }
+ let notLargest = ""
longestWord sería un mejor nombre para esta variable. Al fin y al cabo,
se trata precisamente de la palabra más larga. notLargest es precisamente
lo contrario :<
------------------------------
In src/functions-and-arrays.js
<#3755 (comment)>
:
> + for (let i = 0; i < numbers.length; i++) {
+ if (typeof numbers[i] === String) {
+ return sumOfNumbersAndOthers += numbers[i]
+ }
+ if (typeof numbers[i] === Number) {
+ return sumOfNumbersAndOthers += numbers.length
+ }
+ if (typeof numbers[i] === Boolean) {
+ }
typeof devuelve una string. typeof 5 === "number"
Así que estos condicionales nunca van a cumplirse :(
if (typeof numbers[i] === "string") sería correcto en vez de if (typeof
numbers[i] === String)
------------------------------
In src/functions-and-arrays.js
<#3755 (comment)>
:
>
// Iteration #6: Find elements
const wordsFind = ['machine', 'subset', 'trouble', 'starting', 'matter', 'eating', 'truth', 'disobedience'];
-function doesWordExist() {}
-
+function doesWordExist(wordsFind, wordToSearch) {
+ if (wordsFind.length == 0) {
+ return null;
+ }
+ return wordsFind.includes(wordToSearch)
Niceee
—
Reply to this email directly, view it on GitHub
<#3755 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A65ZLTTTGCAUAUIXP2ELHD3XBFLI5ANCNFSM6AAAAAAW5TJCIE>
.
You are receiving this because you authored the thread.Message ID:
<ironhack-labs/lab-javascript-functions-and-arrays/pull/3755/review/1385538149
@github.com>
|
|
This pull request has been automatically marked as stale because it didn't have any recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This pull request is closed. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Me ha faltado alguna que otra cosa por entender sobre todo los bonus pero por lo demás todo bien. Seguiremos viendo como mejorarlo