Skip to content

[PTMAD102022] DANIEL OLEA GARCIA #3404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

OleaOnize
Copy link

Ejercicio resuelto menos una parte del #6 y bonus final

@marco238
Copy link

marco238 commented Nov 5, 2022

hola Daniel! Te dejo algo de feedback en el código. Pero en general muy buen trabajo!!! 🚀

@marco238
Copy link

marco238 commented Nov 5, 2022

Por el bonus ni te preocupes! Buen trabajo!!!

}
for (let i = 0 ; i < wordsFind.length ; i++){
if (!wordsFind[i].includes(word)){
return false;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aquí lo que te está pasando es que en la primera iteración del "for", estás haciendo un return que termina la función y deja de analizar el resto de iteraciones.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

intenta con una variable auxiliar que empiece siendo "false":

function doesWordExist(wordsFind, word) {
  if (wordsFind.length === 0) {
    return null;
  }
  let exists = false;
  for (let i = 0 ; i < wordsFind.length ; i++){
    if (wordsFind[i].includes(word)){
      exists = true;
    }
  }
  return exists;
}

@stale
Copy link

stale bot commented Jan 8, 2023

This pull request has been automatically marked as stale because it didn't have any recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

1 similar comment
@stale
Copy link

stale bot commented Apr 7, 2023

This pull request has been automatically marked as stale because it didn't have any recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 7, 2023
@stale
Copy link

stale bot commented Jun 7, 2023

This pull request is closed. Thank you.

@stale stale bot closed this Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants