WDPT-REMOTE-SEP-2021-Karla-Jaramillo #2577
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ronhack-labs#3, Iteration ironhack-labs#4, Iteration ironhack-labs#5, Iteration ironhack-labs#6, Iteration ironhack-labs#7, Bonus Iteration ironhack-labs#3.1, Bonus Iteration ironhack-labs#4.1
tomasyaya
reviewed
Sep 21, 2021
There was a problem hiding this comment.
Congratulations on the dedication you have put into the bonus!
Is impressive !
@karlajaramillo
| } | ||
|
|
||
| words.forEach( word => { | ||
| //check if the length of the word is > the maximum length |
| // check if it the argument is a valid array | ||
| let notValidArray = Array.isArray(numbers); | ||
| if(!notValidArray) { | ||
| throw `Not a valid array`; |
There was a problem hiding this comment.
Great catch here, do I think the lab asked you to just return null?
|
|
||
| numbers.forEach(item => { | ||
| // check valid values | ||
| let notValid = typeof item === 'object' || Array.isArray(item); |
|
This pull request has been automatically marked as stale because it didn't have any recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This pull request is closed. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… #5, Iteration #6, Iteration #7, Bonus Iteration #3.1, Bonus Iteration #4.1