feat: Put ArrayPool usage into try-finally

Author: ironcev

src/GettingThingsDone.ApplicationCore/Services/LegacyExchangeActionFormat.cs

@@ -59,17 +59,23 @@ public static string ToLegacyFormat(this Action action)
         {            
             var buffer = ArrayPool<char>.Shared.Rent(TotalWidth);
 
-            Array.Fill(buffer, ' ');
-
-            action.Title?.CopyTo(0, buffer, TitleStart, Math.Min(TitleWidth, action.Title.Length));
-
-            action.DueDate?.ToString(DueDateFormat).CopyTo(0, buffer, DueDateStart, DueDateWidth);
+            string result;
+            try
+            {
+                Array.Fill(buffer, ' ');
 
-            var result = new string(buffer);
+                action.Title?.CopyTo(0, buffer, TitleStart, Math.Min(TitleWidth, action.Title.Length));
 
-            ArrayPool<char>.Shared.Return(buffer);
+                action.DueDate?.ToString(DueDateFormat).CopyTo(0, buffer, DueDateStart, DueDateWidth);
 
+                result = new string(buffer);
+            }
+            finally 
+            {
+                ArrayPool<char>.Shared.Return(buffer);
+            }
+            
             return result;
         }
     }
-}
+}

src/GettingThingsDone.ApplicationCore/Services/LegacyExchangeActionListFormat.cs

@@ -39,14 +39,20 @@ public static string ToLegacyFormat(this ActionList actionList)
         {
             var buffer = ArrayPool<char>.Shared.Rent(TotalWidth);
 
-            Array.Fill(buffer, ' ');
-
-            actionList.Name?.CopyTo(0, buffer, TitleStart, Math.Min(TitleWidth, actionList.Name.Length));
-
-            var result = new string(buffer);
+            string result;
+            try
+            {
+                Array.Fill(buffer, ' ');
 
-            ArrayPool<char>.Shared.Return(buffer);
+                actionList.Name?.CopyTo(0, buffer, TitleStart, Math.Min(TitleWidth, actionList.Name.Length));
 
+                result = new string(buffer);
+            }
+            finally
+            {
+                ArrayPool<char>.Shared.Return(buffer);
+            }
+            
             return result;
         }
     }

src/GettingThingsDone.ApplicationCore/Services/LegacyExchangeProjectFormat.cs

@@ -39,13 +39,19 @@ public static string ToLegacyFormat(this Project project)
         {
             var buffer = ArrayPool<char>.Shared.Rent(TotalWidth);
 
-            Array.Fill(buffer, ' ');
-
-            project.Name?.CopyTo(0, buffer, TitleStart, Math.Min(TitleWidth, project.Name.Length));
+            string result;
+            try
+            {
+                Array.Fill(buffer, ' ');
 
-            var result = new string(buffer);
+                project.Name?.CopyTo(0, buffer, TitleStart, Math.Min(TitleWidth, project.Name.Length));
 
-            ArrayPool<char>.Shared.Return(buffer);
+                result = new string(buffer);
+            }
+            finally 
+            {
+                ArrayPool<char>.Shared.Return(buffer);
+            }
 
             return result;
         }