-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement iRODS PyFilesystem2 module #490
Comments
oh, very interesting. we'll definitely investigate and have an opinion soon. thanks! |
Looks like it may be a good thing on which to build a bilateral,ssh-powered, "rsync-like" file syncher. |
Interesting... could also be a useful abstraction for rsync, ingest, lots of things.
|
@d-w-moore my plan was to give it a go today to work on this, I might use this as a starting point though I have to say I'm not particularly familiar with iRODS nor the python client. |
See WIP here: https://github.com/hechth/fs-irods |
@hechth - You're welcome to mine and play with this code all you want... Meanwhile I'll probably be fleshing it out today into something a little more complete and real. It needs more methods, thread safety and maybe more. |
@d-w-moore We can also schedule acall to coordinate these efforts? I think it will be a bit more complex so it might take time. I started with the skeleton for the extension and checked the options for how to deal with the session, but I!d be very curious to hear how you would implement it. My current approach is to always open a new session for each command so that they are self-contained in that sense. Also implementing unit tests is quite tricky as everything needs to be mocked basically |
@hechth Yes, a call would be good - maybe early next week, Monday (20.11) - Wednesday(22.11) sometime? At any rate, I don't I will be getting as far on it today as I thought. Regarding the session: that represents state, and my impression is that pyfilesystem2 doesn't deal much with that, beyond storing it in the filesystem object and using _lock to guard against thread conflicts. The global |
@d-w-moore monday sounds good. Which timezone are you in? I'll continue a bit still today and then I can give an overview on Monday and we can refine the implementation? |
Great. I'm in EST time zone |
@hechth changing the
And basing on the python-irodsclient from this dev branch: we can now run this code After having created
Results are:
|
I think this can be closed as the repo has become a somewhat standalone resource I think and we can move discussions to the issues over there? Thanks for the useful starting points, it has been very helpful :) |
Just want to confirm that when you say, the repo, you're referring to https://github.com/hechth/fs-irods? |
Yes, I am. |
Cool cool. Feel free to open new issues here if you encounter problems with the PRC. |
It would be really great if there was a PyFilesystem2 implementation for iRODS like
fs-irods
(see here).Should this be part of the python-irodsclient or an external library based on the python-irodsclient and PyFilesystem2?
I think it would make sense to implement it as a standalone library - I would start with an implementation and then we could potentially transfer the project into the irods organization for better visibility? Please let me know your thoughts on this or if you are aware that something similar has already been implemented.
The text was updated successfully, but these errors were encountered: