Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unit description should not be an unrelated unit #134

Open
crotwell opened this issue Jul 27, 2021 · 0 comments
Open

unit description should not be an unrelated unit #134

crotwell opened this issue Jul 27, 2021 · 0 comments

Comments

@crotwell
Copy link
Contributor

Example from stationxml docs:

http://docs.fdsn.org/projects/stationxml/en/latest/response.html#ysi-44031-thermistor

<Stage number="5">
              <Coefficients name=" DECIMATION">
              <InputUnits>
                 <Name>counts</Name>
                 <Description>Volts</Description>
              </InputUnits>

Checking description is probably too hard in general, which is why I think description should be omitted if the unit is SI. But perhaps checking to see if the Description actually is a unit and that it doesn't match the name would be useful.

Alternatively, a warn if unit has a description and unit Name is in the list of well known units to the validator to discourage using Description when it really doesn't add anything?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant