Add include OpCode #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds an OpCode to emit when encontering a PHPCfg\Expr\Include_ in compile. Support for it isn't included in the VM, JIT, or AOT, but at least it allows bin/print.php to handle files that have an include statement without throwing an exception while trying to generate the OpCodes. Fixes ircmaxell#62.
ircmaxell
reviewed
Apr 25, 2019
There is no reason to use runtime->run to spawn a new VM when including a file, so instead push a frame onto the existing one. Co-Authored-By: driusan <driusan@gmail.com>
ircmaxell
reviewed
Apr 26, 2019
The break is unreachable. Co-Authored-By: driusan <driusan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an OpCode to emit when encontering a PHPCfg\Expr\Include_
in compile.
Support for it isn't included in the JIT, or AOT, but at least
it allows bin/print.php to handle files that have an include
statement without throwing an exception while trying to generate the
OpCodes.
Fixes #62.