This repository was archived by the owner on Aug 21, 2024. It is now read-only.
IR-3575 playmode on scene change #10985
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lay mode on scene loading
SamMazerIR
requested review from
SYBIOTE,
aditya-mitra,
CITIZENDOT,
speigg,
AidanCaruso,
MichaelEstes and
MbfloydIR
as code owners
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
moving start/stop playmode into its own functions file, try exiting play mode on scene loading
References
https://tsu.atlassian.net/browse/IR-3575
QA Steps
open a scene, enter playmode, load a new scene without manually leaving playmode.
you should be able to properly see playmode has ended once the new scene is loaded, and you can enter/exit playmode as expected in the new scene
Repeat to your hearts content