Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc cleanup and types updates #1272

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+66 −16
Open

Misc cleanup and types updates #1272

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c349a91
Misc cleanup and types updates
Carreau Oct 17, 2024
668631d
Apply suggestions from code review
Carreau Oct 17, 2024
f805287
BaseThread
Carreau Oct 17, 2024
f0a3aff
allow none
Carreau Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
BaseThread
  • Loading branch information
@Carreau
Carreau committed Oct 17, 2024
commit f805287c04e0b46e1f287bc9ef9aaeb30f99ec84
8 changes: 4 additions & 4 deletions ipykernel/kernelapp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
from io import FileIO, TextIOWrapper
from logging import StreamHandler
from pathlib import Path
from threading import Thread

import zmq
import zmq.asyncio
Expand Down Expand Up @@ -55,6 +54,7 @@
from .ipkernel import IPythonKernel
from .parentpoller import ParentPollerUnix, ParentPollerWindows
from .shellchannel import ShellChannelThread
from .thread import BaseThread
from .zmqshell import ZMQInteractiveShell

# -----------------------------------------------------------------------------
Expand Down Expand Up @@ -143,9 +143,9 @@ class IPKernelApp(BaseIPythonApplication, InteractiveShellApp, ConnectionFileMix
debug_shell_socket = Any()
stdin_socket = Any()
iopub_socket = Any()
iopub_thread: Thread
control_thread: Thread
shell_channel_thread: Thread
iopub_thread: BaseThread
control_thread: BaseThread
shell_channel_thread: BaseThread

_ports = Dict()

Expand Down
Loading