Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc cleanup and types updates #1272

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Misc cleanup and types updates #1272

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c349a91
Misc cleanup and types updates
Carreau Oct 17, 2024
668631d
Apply suggestions from code review
Carreau Oct 17, 2024
f805287
BaseThread
Carreau Oct 17, 2024
f0a3aff
allow none
Carreau Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
allow none
  • Loading branch information
@Carreau
Carreau committed Oct 17, 2024
commit f0a3aff355df369f49e91fb710cc24c8bae1dc7f
2 changes: 1 addition & 1 deletion ipykernel/kernelbase.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ class Kernel(SingletonConfigurable):
control_tasks: t.Any = List()

debug_shell_socket = Any()
control_thread: Thread
control_thread: t.Optional[Thread] = None
shell_channel_thread: Thread

iopub_socket = Any()
Expand Down
2 changes: 2 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,6 +272,8 @@ ignore = [
"G002",
# `open()` should be replaced by `Path.open()`
"PTH123",
# use `X | Y` for type annotations, this does not works for dynamic getting type hints on older python
"UP007",
]
unfixable = [
# Don't touch print statements
Expand Down
Loading