Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc cleanup and types updates #1272

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+66 −16
Open

Misc cleanup and types updates #1272

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c349a91
Misc cleanup and types updates
Carreau Oct 17, 2024
668631d
Apply suggestions from code review
Carreau Oct 17, 2024
f805287
BaseThread
Carreau Oct 17, 2024
f0a3aff
allow none
Carreau Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review 
Co-authored-by: David Brochart <david.brochart@gmail.com>
  • Loading branch information
@Carreau @davidbrochart
Carreau and davidbrochart authored Oct 17, 2024
commit 668631dda5a3d2569dfdec56ce8cdd3660636edd
4 changes: 2 additions & 2 deletions ipykernel/kernelbase.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,7 @@ def __init__(self, **kwargs):
# function is not called
warnings.warn(
"`do_debug_request` will be required to be a coroutine "
"functions in the future. coroutine functions have ben supported "
"function in the future. Coroutine functions have been supported "
"since ipykernel 6.0 (2021)",
DeprecationWarning,
stacklevel=2,
Expand Down Expand Up @@ -1028,7 +1028,7 @@ async def debug_request(self, socket, ident, parent):
# If this is incorrect, remove `debug_request` from the deprecated message types
# at the beginning of this class
warnings.warn(
"debug_request is deprecated in kernel_base since ipykernel 6.10"
"`debug_request` is deprecated in `kernelbase.py` since ipykernel 6.10"
" (2022). It is only part of IPython parallel. Did you mean do_debug_request ?",
DeprecationWarning,
stacklevel=2,
Expand Down
Loading