-
-
Notifications
You must be signed in to change notification settings - Fork 377
Comparing changes
Open a pull request
base repository: ipython/ipykernel
base: v6.3.1
head repository: ipython/ipykernel
compare: 1ba6b48a97877ff7a564af32c531618efb7d2a57
- 12 commits
- 10 files changed
- 5 contributors
Commits on Sep 1, 2021
-
Update some warnings with instructions and version number.
I came across this when trying to reproduce an unrelated bug with someone in an outdated environment, but at least having the version number will make us more confident when e remove the conditional branch later.
Configuration menu - View commit details
-
Copy full SHA for cf2d56e - Browse repository at this point
Copy the full SHA cf2d56eView commit details -
Merge pull request #761 from Carreau/better-deprecation
Update some warnings with instructions and version number.
Configuration menu - View commit details
-
Copy full SHA for 3c6037f - Browse repository at this point
Copy the full SHA 3c6037fView commit details
Commits on Sep 6, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 0e7cf85 - Browse repository at this point
Copy the full SHA 0e7cf85View commit details -
Merge pull request #765 from martinRenou/fix_undefined_var
Fix undefined variable
Steven Silvester authoredSep 6, 2021 Configuration menu - View commit details
-
Copy full SHA for d14db6a - Browse repository at this point
Copy the full SHA d14db6aView commit details -
Stop using deprecated recv_multipart when using in-process socket.
Found while working on napari/napari#3314 This should be the right fix, as BackgroundSocket is used only in inprocess kernel, and while in general iopub_socket looks like it can be `Any()` for this particular class we have a trait saying iopub_socket has to be a BackgroundSocket The recv in jupyter_client side (which is called by the line I change here) is def recv(self, socket, mode=zmq.NOBLOCK, content=True, copy=True): """Receive and unpack a message. Parameters ---------- socket : ZMQStream or Socket The socket or stream to use in receiving. Returns ------- [idents], msg [idents] is a list of idents and msg is a nested message dict of same format as self.msg returns. """ if isinstance(socket, ZMQStream): socket = socket.socket try: msg_list = socket.recv_multipart(mode, copy=copy) # this will trigger deprecation warning except zmq.ZMQError as e: ... And I doubt we want to make that aware of background socket.
Configuration menu - View commit details
-
Copy full SHA for 168548e - Browse repository at this point
Copy the full SHA 168548eView commit details -
Don't assume kernels have loops.
In particular the in-process kernels don't. This does not fix all the issues in particular the quit() and exit() autocaller that become no-op, but that's another story
Configuration menu - View commit details
-
Copy full SHA for 1483408 - Browse repository at this point
Copy the full SHA 1483408View commit details
Commits on Sep 7, 2021
-
Make ipykernel work without debugpy
debugpy is an optional dependency because only frontends with debugging support (Jupyter lab) can really use its features. Fixes: #712
Configuration menu - View commit details
-
Copy full SHA for 544fdb2 - Browse repository at this point
Copy the full SHA 544fdb2View commit details -
Merge pull request #762 from Carreau/deprecated
Stop using deprecated recv_multipart when using in-process socket.
Configuration menu - View commit details
-
Copy full SHA for c810559 - Browse repository at this point
Copy the full SHA c810559View commit details -
Configuration menu - View commit details
-
Copy full SHA for a7aa5a0 - Browse repository at this point
Copy the full SHA a7aa5a0View commit details -
Merge pull request #708 from martinRenou/clean_json_clean
Make json_clean a no-op for jupyter-client >= 7
Steven Silvester authoredSep 7, 2021 Configuration menu - View commit details
-
Copy full SHA for 3cee9ce - Browse repository at this point
Copy the full SHA 3cee9ceView commit details -
Merge pull request #766 from Carreau/no-loops
Don't assume kernels have loops.
Steven Silvester authoredSep 7, 2021 Configuration menu - View commit details
-
Copy full SHA for bd0abb4 - Browse repository at this point
Copy the full SHA bd0abb4View commit details
Commits on Sep 9, 2021
-
Merge pull request #767 from frenzymadness/debugpy_optional
Make ipykernel work without debugpy
Configuration menu - View commit details
-
Copy full SHA for 1ba6b48 - Browse repository at this point
Copy the full SHA 1ba6b48View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v6.3.1...1ba6b48a97877ff7a564af32c531618efb7d2a57