Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: ipython/ipykernel
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v6.3.1
Choose a base ref
...
head repository: ipython/ipykernel
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 1ba6b48a97877ff7a564af32c531618efb7d2a57
Choose a head ref
  • 12 commits
  • 10 files changed
  • 5 contributors

Commits on Sep 1, 2021

  1. Update some warnings with instructions and version number.

    I came across this when trying to reproduce an unrelated bug with
    someone in an outdated environment, but at least having the version
    number will make us more confident when e remove the conditional branch
    later.
    Carreau committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    cf2d56e View commit details
    Browse the repository at this point in the history
  2. Merge pull request #761 from Carreau/better-deprecation

    Update some warnings with instructions and version number.
    minrk authored Sep 1, 2021
    Configuration menu
    Copy the full SHA
    3c6037f View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2021

  1. Fix undefined variable

    + Fix some pep8 issues
    martinRenou committed Sep 6, 2021
    Configuration menu
    Copy the full SHA
    0e7cf85 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #765 from martinRenou/fix_undefined_var

    Fix undefined variable
    Steven Silvester authored Sep 6, 2021
    Configuration menu
    Copy the full SHA
    d14db6a View commit details
    Browse the repository at this point in the history
  3. Stop using deprecated recv_multipart when using in-process socket.

    Found while working on napari/napari#3314
    
    This should be the right fix, as BackgroundSocket is used only
    in inprocess kernel, and while in general iopub_socket looks like it
    can be `Any()` for this particular class we have a trait saying
    iopub_socket has to be a BackgroundSocket
    
    The recv in jupyter_client side (which is called by the line I change
    here) is
    
        def recv(self, socket, mode=zmq.NOBLOCK, content=True, copy=True):
            """Receive and unpack a message.
    
            Parameters
            ----------
            socket : ZMQStream or Socket
                The socket or stream to use in receiving.
    
            Returns
            -------
            [idents], msg
                [idents] is a list of idents and msg is a nested message dict of
                same format as self.msg returns.
            """
            if isinstance(socket, ZMQStream):
                socket = socket.socket
            try:
                msg_list = socket.recv_multipart(mode, copy=copy) # this will trigger deprecation warning
            except zmq.ZMQError as e:
                ...
    
    And I doubt we want to make that aware of background socket.
    Carreau committed Sep 6, 2021
    Configuration menu
    Copy the full SHA
    168548e View commit details
    Browse the repository at this point in the history
  4. Don't assume kernels have loops.

    In particular the in-process kernels don't.
    
    This does not fix all the issues in particular the quit() and exit()
    autocaller that become no-op, but that's another story
    Carreau committed Sep 6, 2021
    Configuration menu
    Copy the full SHA
    1483408 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2021

  1. Make ipykernel work without debugpy

    debugpy is an optional dependency because only frontends with
    debugging support (Jupyter lab) can really use its features.
    
    Fixes: #712
    frenzymadness committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    544fdb2 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #762 from Carreau/deprecated

    Stop using deprecated recv_multipart when using in-process socket.
    minrk authored Sep 7, 2021
    Configuration menu
    Copy the full SHA
    c810559 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a7aa5a0 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #708 from martinRenou/clean_json_clean

    Make json_clean a no-op for jupyter-client >= 7
    Steven Silvester authored Sep 7, 2021
    Configuration menu
    Copy the full SHA
    3cee9ce View commit details
    Browse the repository at this point in the history
  5. Merge pull request #766 from Carreau/no-loops

    Don't assume kernels have loops.
    Steven Silvester authored Sep 7, 2021
    Configuration menu
    Copy the full SHA
    bd0abb4 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2021

  1. Merge pull request #767 from frenzymadness/debugpy_optional

    Make ipykernel work without debugpy
    minrk authored Sep 9, 2021
    Configuration menu
    Copy the full SHA
    1ba6b48 View commit details
    Browse the repository at this point in the history
Loading