Skip to content

Commit 1632cb3

Browse files
authored
Merge branch 'main' into pre-commit-ci-update-config
2 parents 1d869d1 + 2b43f5e commit 1632cb3

File tree

3 files changed

+51
-9
lines changed

3 files changed

+51
-9
lines changed

.github/workflows/ci.yml

Lines changed: 44 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ jobs:
6161
- name: Install hatch
6262
run: |
6363
python --version
64-
python -m pip install hatch
64+
python -m pip install hatch "virtualenv<21"
6565
6666
- name: Run the tests
6767
timeout-minutes: 15
@@ -104,6 +104,12 @@ jobs:
104104
runs-on: ubuntu-latest
105105
steps:
106106
- uses: actions/checkout@v6
107+
108+
- name: Preinstall hatch and virtualenv
109+
run: |
110+
python --version
111+
python -m pip install hatch "virtualenv<21"
112+
107113
- uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
108114
- name: Run Linters
109115
run: |
@@ -116,7 +122,14 @@ jobs:
116122
runs-on: ubuntu-latest
117123
steps:
118124
- uses: actions/checkout@v6
125+
126+
- name: Preinstall hatch and virtualenv
127+
run: |
128+
python --version
129+
python -m pip install hatch "virtualenv<21"
130+
119131
- uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
132+
120133
- uses: jupyter-server/jupyter_releaser/.github/actions/check-release@v2
121134
with:
122135
token: ${{ secrets.GITHUB_TOKEN }}
@@ -125,7 +138,14 @@ jobs:
125138
runs-on: ubuntu-latest
126139
steps:
127140
- uses: actions/checkout@v6
141+
142+
- name: Preinstall hatch and virtualenv
143+
run: |
144+
python --version
145+
python -m pip install hatch "virtualenv<21"
146+
128147
- uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
148+
129149
- name: Build API docs
130150
run: |
131151
hatch run docs:api
@@ -148,6 +168,11 @@ jobs:
148168
- name: Checkout
149169
uses: actions/checkout@v6
150170

171+
- name: Preinstall hatch and virtualenv
172+
run: |
173+
python --version
174+
python -m pip install hatch "virtualenv<21"
175+
151176
- name: Base Setup
152177
uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
153178

@@ -170,11 +195,21 @@ jobs:
170195
runs-on: ubuntu-latest
171196
steps:
172197
- uses: actions/checkout@v6
198+
199+
- uses: actions/setup-python@v6
200+
with:
201+
python-version: "3.10"
202+
203+
- name: Preinstall hatch and virtualenv
204+
run: |
205+
python --version
206+
python -m pip install hatch "virtualenv<21"
207+
173208
- name: Base Setup
174209
uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
175210
with:
176211
dependency_type: minimum
177-
python_version: "3.10"
212+
python_version: ${{ matrix.python-version }}
178213

179214
- name: List installed packages
180215
run: |
@@ -191,10 +226,17 @@ jobs:
191226
steps:
192227
- name: Checkout
193228
uses: actions/checkout@v6
229+
230+
- name: Preinstall hatch and virtualenv
231+
run: |
232+
python --version
233+
python -m pip install hatch "virtualenv<21"
234+
194235
- name: Base Setup
195236
uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
196237
with:
197238
dependency_type: pre
239+
198240
- name: Run the tests
199241
run: |
200242
hatch run test:nowarn

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
### Enhancements made
1515

1616
- Made IOPubThread constructor backward compatible [#1492](https://github.com/ipython/ipykernel/pull/1492) ([@JohanMabille](https://github.com/JohanMabille), [@SylvainCorlay](https://github.com/SylvainCorlay), [@ianthomas23](https://github.com/ianthomas23), [@minrk](https://github.com/minrk))
17-
- Advertizes kernel protocol 5.5 [#1488](https://github.com/ipython/ipykernel/pull/1488) ([@JohanMabille](https://github.com/JohanMabille), [@ianthomas23](https://github.com/ianthomas23))
17+
- Advertises kernel protocol 5.5 [#1488](https://github.com/ipython/ipykernel/pull/1488) ([@JohanMabille](https://github.com/JohanMabille), [@ianthomas23](https://github.com/ianthomas23))
1818
- Upgrade to jupyter_client 8.8.0 [#1487](https://github.com/ipython/ipykernel/pull/1487) ([@JohanMabille](https://github.com/JohanMabille), [@ianthomas23](https://github.com/ianthomas23))
1919
- Implement kernel-side callstack filtering for internal frames [#1481](https://github.com/ipython/ipykernel/pull/1481) ([@arjxn-py](https://github.com/arjxn-py), [@JohanMabille](https://github.com/JohanMabille), [@ianthomas23](https://github.com/ianthomas23))
2020

ipykernel/kernelbase.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -869,7 +869,7 @@ async def execute_request(self, stream, ident, parent):
869869
subshell_id = parent["header"].get("subshell_id")
870870
self._abort_queues(subshell_id)
871871

872-
def do_execute(
872+
async def do_execute(
873873
self,
874874
code,
875875
silent,
@@ -904,7 +904,7 @@ async def complete_request(self, stream, ident, parent):
904904
matches = json_clean(matches)
905905
self.session.send(stream, "complete_reply", matches, parent, ident)
906906

907-
def do_complete(self, code, cursor_pos):
907+
async def do_complete(self, code, cursor_pos):
908908
"""Override in subclasses to find completions."""
909909
return {
910910
"matches": [],
@@ -940,7 +940,7 @@ async def inspect_request(self, stream, ident, parent):
940940
msg = self.session.send(stream, "inspect_reply", reply_content, parent, ident)
941941
self.log.debug("%s", msg)
942942

943-
def do_inspect(self, code, cursor_pos, detail_level=0, omit_sections=()):
943+
async def do_inspect(self, code, cursor_pos, detail_level=0, omit_sections=()):
944944
"""Override in subclasses to allow introspection."""
945945
return {"status": "ok", "data": {}, "metadata": {}, "found": False}
946946

@@ -964,7 +964,7 @@ async def history_request(self, stream, ident, parent):
964964
msg = self.session.send(stream, "history_reply", reply_content, parent, ident)
965965
self.log.debug("%s", msg)
966966

967-
def do_history(
967+
async def do_history(
968968
self,
969969
hist_access_type,
970970
output,
@@ -1104,7 +1104,7 @@ async def shutdown_request(self, stream, ident, parent):
11041104
shell_io_loop = self.shell_stream.io_loop
11051105
shell_io_loop.add_callback(shell_io_loop.stop)
11061106

1107-
def do_shutdown(self, restart):
1107+
async def do_shutdown(self, restart):
11081108
"""Override in subclasses to do things when the frontend shuts down the
11091109
kernel.
11101110
"""
@@ -1130,7 +1130,7 @@ async def is_complete_request(self, stream, ident, parent):
11301130
reply_msg = self.session.send(stream, "is_complete_reply", reply_content, parent, ident)
11311131
self.log.debug("%s", reply_msg)
11321132

1133-
def do_is_complete(self, code):
1133+
async def do_is_complete(self, code):
11341134
"""Override in subclasses to find completions."""
11351135
return {"status": "unknown"}
11361136

0 commit comments

Comments
 (0)