Skip to content

Commit 1630c4f

Browse files
authored
Temporarily revert "Test changing base method to async after (#1464)" (#1493)
Temporarily revert commit 31ec38a (PR #1464) so that it will not be included in the upcoming 7.2.0 release as discussed in #1464 (comment). This will be re-applied to the `main` branch after the 7.2.0 release.
2 parents a2d47a2 + 8086199 commit 1630c4f

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

ipykernel/kernelbase.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -869,7 +869,7 @@ async def execute_request(self, stream, ident, parent):
869869
subshell_id = parent["header"].get("subshell_id")
870870
self._abort_queues(subshell_id)
871871

872-
async def do_execute(
872+
def do_execute(
873873
self,
874874
code,
875875
silent,
@@ -904,7 +904,7 @@ async def complete_request(self, stream, ident, parent):
904904
matches = json_clean(matches)
905905
self.session.send(stream, "complete_reply", matches, parent, ident)
906906

907-
async def do_complete(self, code, cursor_pos):
907+
def do_complete(self, code, cursor_pos):
908908
"""Override in subclasses to find completions."""
909909
return {
910910
"matches": [],
@@ -940,7 +940,7 @@ async def inspect_request(self, stream, ident, parent):
940940
msg = self.session.send(stream, "inspect_reply", reply_content, parent, ident)
941941
self.log.debug("%s", msg)
942942

943-
async def do_inspect(self, code, cursor_pos, detail_level=0, omit_sections=()):
943+
def do_inspect(self, code, cursor_pos, detail_level=0, omit_sections=()):
944944
"""Override in subclasses to allow introspection."""
945945
return {"status": "ok", "data": {}, "metadata": {}, "found": False}
946946

@@ -964,7 +964,7 @@ async def history_request(self, stream, ident, parent):
964964
msg = self.session.send(stream, "history_reply", reply_content, parent, ident)
965965
self.log.debug("%s", msg)
966966

967-
async def do_history(
967+
def do_history(
968968
self,
969969
hist_access_type,
970970
output,
@@ -1104,7 +1104,7 @@ async def shutdown_request(self, stream, ident, parent):
11041104
shell_io_loop = self.shell_stream.io_loop
11051105
shell_io_loop.add_callback(shell_io_loop.stop)
11061106

1107-
async def do_shutdown(self, restart):
1107+
def do_shutdown(self, restart):
11081108
"""Override in subclasses to do things when the frontend shuts down the
11091109
kernel.
11101110
"""
@@ -1130,7 +1130,7 @@ async def is_complete_request(self, stream, ident, parent):
11301130
reply_msg = self.session.send(stream, "is_complete_reply", reply_content, parent, ident)
11311131
self.log.debug("%s", reply_msg)
11321132

1133-
async def do_is_complete(self, code):
1133+
def do_is_complete(self, code):
11341134
"""Override in subclasses to find completions."""
11351135
return {"status": "unknown"}
11361136

0 commit comments

Comments
 (0)