Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ProvideBitswap with new API based on IPIP-378 #403

Open
lidel opened this issue Aug 25, 2023 · 5 comments
Open

Replace ProvideBitswap with new API based on IPIP-378 #403

lidel opened this issue Aug 25, 2023 · 5 comments

Comments

@lidel
Copy link

lidel commented Aug 25, 2023

@masih filling this as a placeholder, feel free to rephrase this to better reflect what needs to happen.

This project depends on undocumented and deprecated ProvideBitswap from boxo.

IPFS ecosystem is shifting towards nodes having both HTTP and Bitswap as retrieval protocols, and we would like to avoid separate announcement for each protocol.

IPIP-378 aims to introduce a specification for how provider PUTs are expected to work in cases when CID is provided over more than just bitswap

Once we have that, projects like this one should stop using ProvideBitswap and switch to the new API based on IPIP-378.

Ref.

@lidel
Copy link
Author

lidel commented Oct 5, 2023

Hi, checking in again.

  • IPFS Stewards would like to remove undocumented and buggy bitswap provides API from Boxo/Kubo.

@masih @willscott Do you have an alternative way of serving your users now, since we've talked about this last time? Is it safe to remove ProvideBitswap now, or should we avoid making waves and keep code in Kubo as-is until IPIP-378 is ready as replacement?

Asking because https://github.com/ipni/index-provider/#configuring-kubo-to-advertise-content-onto-ipni-experimental still points your users towards the ProvideBitswap (unsupported API).

@willscott
Copy link
Member

cc @ischasny

@ischasny
Copy link
Contributor

ischasny commented Oct 5, 2023

Hi @lidel - is there an alternative API that we can switch over if ProvideBitswap is removed?

@lidel
Copy link
Author

lidel commented Oct 5, 2023

@ischasny we want to define one in IPIP-378 and implement that in Kubo and Boxo, but it had no engagement for a while (see question ipfs/specs#378 (comment)).

(Ok if you say "keep old thing for now", just planning Q4 and wondering if we could do cleanup now, before IPIP, or after, in 2024)

@ischasny
Copy link
Contributor

ischasny commented Oct 6, 2023

@lidel would be great if you keep it for now, until an alternative is available. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants