Prints the sensor reading incorrectly for non-analog sensors in sdr sensor commands

[AlexanderAmelkin]

Reported by: mareedu srinivasa rao
Original Ticket: ipmitool/bugs/490

Hi IPMITOOL Team,

This is regarding ipmitool sdr and ipmitool sensor o/p.
ipmitool has an issue where it prints the sensor reading incorrectly for discrete and threshold type sensors.
IPMI specification’s Get Sensor Reading command says that Get Sensor Reading response byte 2 has the sensor reading, but only for sensors returning an analog reading. Ipmitool is returning this byte as a reading for discrete and threshold sensors as well.
We have identified bux in sensor and sdr command response data parsing.

Please find the attached patch and o/p after fix and before fix.
Spec for get sensor reading.

Br,
MSR

[AlexanderAmelkin]

sensor and sdr o/p

Original comment by: mareedu srinivasa rao

[AlexanderAmelkin]

get sensor reading snap shot from ipmi spec

Original comment by: mareedu srinivasa rao

[AlexanderAmelkin]

Hi Z,

Can i get update on this.

Br,
MSR

Original comment by: mareedu srinivasa rao