Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use the context to thread sessions through all commands #7201

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Stebalien
Copy link
Member

  • Ensure we have a single session per gateway request.
  • Use a session in the ipfs refs command.
  • Start a session before resolving the pin root (also fixes sessions while pinning).
  • Update go-merkledag to reliably create sessions.

part of #7198

@Stebalien Stebalien requested a review from dirkmc April 23, 2020 07:02
@Stebalien Stebalien force-pushed the feat/context-sessions branch 2 times, most recently from 9c618ee to 6b02140 Compare April 23, 2020 07:04
@Stebalien Stebalien added the status/blocked Unable to be worked further until needs are met label Apr 23, 2020
@Stebalien Stebalien mentioned this pull request Apr 23, 2020
4 tasks
core/commands/dag/dag.go Outdated Show resolved Hide resolved
* Ensure we have a single session per gateway request.
* Use a session in the ipfs refs command.
* Start a session before resolving the pin root (also fixes sessions while
  pinning).
* Update go-merkledag to reliably create sessions.

part of #7198
Co-Authored-By: dirkmc <dirkmdev@gmail.com>
@dirkmc
Copy link
Contributor

dirkmc commented Apr 23, 2020

We should probably merge this PR first: Send CANCELs when session context is cancelled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/blocked Unable to be worked further until needs are met
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants